Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/wificlient msys 188 #189

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Conversation

nhjschulz
Copy link
Collaborator

@nhjschulz nhjschulz commented Nov 20, 2024

Make WifiClient.h platform neutral
Compile with platform specific implementations for POSIX and Windows (winsock2).

@nhjschulz nhjschulz linked an issue Nov 20, 2024 that may be closed by this pull request
@nhjschulz nhjschulz marked this pull request as ready for review November 20, 2024 10:06
Copy link
Owner

@BlueAndi BlueAndi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HALTest is not considered, but should.

lib/WiFiNative/src/WifiClientPosix.inl Outdated Show resolved Hide resolved
lib/WiFiNative/src/WifiClientPosix.inl Outdated Show resolved Hide resolved
lib/WiFiNative/src/WifiClientWinsock.inl Outdated Show resolved Hide resolved
lib/WiFiNative/src/WifiClientPosix.inl Outdated Show resolved Hide resolved
platformio.ini Outdated Show resolved Hide resolved
platformio.ini Show resolved Hide resolved
lib/HALSim/src/Board.cpp Outdated Show resolved Hide resolved
lib/WiFiNative/src/WifiClientPosix.inl Outdated Show resolved Hide resolved
lib/HALSim/src/Board.cpp Outdated Show resolved Hide resolved
@@ -32,164 +32,9 @@
/******************************************************************************
* Includes
*****************************************************************************/
#include "WiFiClient.h"
#include <Logging.h>
#if _WIN32
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"#ifdef" required.

@BlueAndi BlueAndi merged commit a224b33 into release/v1.0.x Nov 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Make WiFiClient socket connection compatible with MSYS2
2 participants