Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mm/s #153

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Use mm/s #153

merged 5 commits into from
Aug 16, 2024

Conversation

gabryelreyes
Copy link
Collaborator

Use mm/s instead of steps/s
Allows for the counterpart to use SI units instead of steps.
Counterpart of BlueAndi/RadonUlzer#146

Closes #114

@gabryelreyes gabryelreyes added the bug Something isn't working label Aug 16, 2024
@gabryelreyes gabryelreyes requested a review from BlueAndi August 16, 2024 10:35
@gabryelreyes gabryelreyes self-assigned this Aug 16, 2024
@nhjschulz
Copy link
Collaborator

Would have been a good oportunity to introduce a user type for speed, something like typedef uint32_t velocity_t.

@BlueAndi
Copy link
Owner

The change has influence on the PIDs, I only saw one change there. What about calculations at all?

@BlueAndi BlueAndi added enhancement New feature or request and removed bug Something isn't working labels Aug 16, 2024
@gabryelreyes
Copy link
Collaborator Author

I tested the simulation and this was the only change required for the stability of the platoon

@BlueAndi
Copy link
Owner

I tested the simulation and this was the only change required for the stability of the platoon

A stability issue means there is a bug or bad parameters. There is no influence just by unit change on stability. ;-)
Anyway you can merge, but the stability issue might still be included and just damped.

@gabryelreyes
Copy link
Collaborator Author

Not even an issue when the maximum value possible changes? Then you may be right, and there may still be an issue

@gabryelreyes gabryelreyes merged commit c227871 into release/v1.0.x Aug 16, 2024
19 checks passed
@BlueAndi
Copy link
Owner

Not even an issue when the maximum value possible changes?

No, there is always a max. speed by electronic + mechanic. Every higher value is limited on RU side. Seems for me the problem is on DCS side, that it assumes the higher speed will work, but it doesn't.

@gabryelreyes gabryelreyes deleted the dev/speed_units branch August 19, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants