-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mm/s #153
Use mm/s #153
Conversation
Would have been a good oportunity to introduce a user type for speed, something like typedef uint32_t velocity_t. |
The change has influence on the PIDs, I only saw one change there. What about calculations at all? |
I tested the simulation and this was the only change required for the stability of the platoon |
A stability issue means there is a bug or bad parameters. There is no influence just by unit change on stability. ;-) |
Not even an issue when the maximum value possible changes? Then you may be right, and there may still be an issue |
No, there is always a max. speed by electronic + mechanic. Every higher value is limited on RU side. Seems for me the problem is on DCS side, that it assumes the higher speed will work, but it doesn't. |
Use mm/s instead of steps/s
Allows for the counterpart to use SI units instead of steps.
Counterpart of BlueAndi/RadonUlzer#146
Closes #114