Moving duration calculation after replies are sent #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would make the reported duration depend on the client's connection speed, is this something we want? Typically the time spent to send the response is proportional to the response size which is already reported, perhaps that's sufficient? |
junderw
pushed a commit
to junderw/electrs
that referenced
this pull request
Sep 4, 2024
Fix: Output index should be u32 to prevent clobbering when over 65536 outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With previous way of response generation duration calculation we were not taking into account time spend on sending replies. I think that should be included in that duration therefore this change.