Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the /headers[/:from_hash[/:count]] endpoint #41

Draft
wants to merge 1 commit into
base: new-index
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/new_index/schema.rs
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,25 @@ impl ChainQuery {
}
}

pub fn get_headers(&self, from: &BlockHash, count: usize) -> Option<Vec<BlockHeader>> {
let _timer = self.start_timer("get_headers");
let store = self.store.indexed_headers.read().unwrap();

if let Some(from_header) = store.header_by_blockhash(from) {
Some(
store
.iter()
.rev()
.skip(self.best_height() - from_header.height())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best height might change between calling best_height() and starting the iteration itself. get_headers should grab one read lock and reuse it to ensure the state is consistent.

.take(count)
.map(|e| e.header().clone())
.collect(),
)
} else {
None
}
}

pub fn get_block_header(&self, hash: &BlockHash) -> Option<BlockHeader> {
let _timer = self.start_timer("get_block_header");
Some(self.header_by_hash(hash)?.header().clone())
Expand Down
34 changes: 34 additions & 0 deletions src/rest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,40 @@ fn handle_request(
path.get(3),
path.get(4),
) {
(&Method::GET, Some(&"headers"), hash, count, None, None) => {
let count = count
.and_then(|c| c.parse::<usize>().ok())
.map(|c| c.max(1).min(2000))
.unwrap_or(2000);
let from_hash = hash
.map(|h| BlockHash::from_hex(h))
.transpose()?
.unwrap_or_else(|| query.chain().best_hash());

let headers = match query.chain().get_headers(&from_hash, count) {
Some(headers) => headers,
None => return Err(HttpError::not_found("Block not found".to_string())),
};

let mut raw = Vec::with_capacity(8 + 80 * headers.len());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header size is different in elements. I think this should be the only difference there.

raw.append(&mut encode::serialize(
&encode::VarInt(headers.len() as u64),
));
for header in headers.into_iter() {
raw.append(&mut encode::serialize(&header));
}

let cache_ttl = match hash {
None => TTL_SHORT,
Some(_) => TTL_SHORT,
};
Ok(Response::builder()
.status(StatusCode::OK)
.header("Content-Type", "application/octet-stream")
.header("Cache-Control", format!("public, max-age={:}", cache_ttl))
.body(Body::from(raw))
.unwrap())
}
(&Method::GET, Some(&"blocks"), Some(&"tip"), Some(&"hash"), None, None) => http_message(
StatusCode::OK,
query.chain().best_hash().to_hex(),
Expand Down