qrmode: fix assert when scanning Specter message QR missing bip32 path

Blockstream · Apr 9, 2024 · 7ea1603 · 7ea1603
1 parent 1249ddd
commit 7ea1603
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/main/wallet.c b/main/wallet.c
@@ -139,7 +139,6 @@ bool wallet_bip32_path_from_str(
     const char* pathstr, const size_t str_len, uint32_t* path, const size_t path_len, size_t* written)
 {
     JADE_ASSERT(pathstr);
-    JADE_ASSERT(str_len);
     JADE_ASSERT(path);
     JADE_ASSERT(path_len);
     JADE_INIT_OUT_SIZE(written);

diff --git a/test_data/msgfile_bad_empty.json b/test_data/msgfile_bad_empty.json
@@ -0,0 +1,6 @@
+{
+  "input": {
+    "filedata": "signmessage  ascii:"
+  },
+  "expected_error": "Invalid bip32 path"
+}
diff --git a/test_data/msgfile_bad_path4.json b/test_data/msgfile_bad_path4.json
@@ -0,0 +1,6 @@
+{
+  "input": {
+    "filedata": "signmessage  ascii:path missing"
+  },
+  "expected_error": "Invalid bip32 path"
+}