Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix item damage component and event object schema #316

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix item damage component and event object schema #316

merged 2 commits into from
Oct 8, 2024

Conversation

ink0rr
Copy link
Contributor

@ink0rr ink0rr commented Oct 8, 2024

  • Fix item damage component by allowing immediate value instead of only accepting { "value": 1 }
  • Remove event_object_filters.json which have the exact same content as event_object.json, also removed unnecessary pattern match in the event fields

@DaanV2 DaanV2 added enhancement New feature or request hacktoberfest-accepted hacktoberfest-accepted Hacktoberfest Hacktoberfest labels Oct 8, 2024
@DaanV2 DaanV2 merged commit fa09417 into Blockception:main Oct 8, 2024
6 checks passed
DaanV2 pushed a commit that referenced this pull request Nov 9, 2024
@ink0rr @DaanV2
Fix item damage component and event object schema (#316)
d6d0c9a 
* Fix item damage component
* Remove duplicate event schema and unnecessary pattern match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanV2 DaanV2 DaanV2 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest Hacktoberfest hacktoberfest-accepted hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ink0rr @DaanV2