Update minecraft:icon for items #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DinnerBeef You update the auto-generated file 😬 you want to look at: |
|
Also incorrect, both formats are allowed |
|
Will Fix :) |
|
Ok think i did that right this time |
|
That is the correct file but there's a reason that format isn't in the schemas. It's old. Used up to 1.20.50. The format changed after that. The schemas only contain the newest formats |
|
I did not know that then. Will change how i do stuff then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the minecraft:icon item component to be how minecraft does it. See here
Changed minecraft:icon from
"minecraft:icon": "$2.${3:${TM_FILENAME/[\\.].*//}}"to
"minecraft:icon": { "texture": "$2.${3:${TM_FILENAME/[\\.].*//}}" }