Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing documentation to behavior components #30

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Add missing documentation to behavior components #30

merged 2 commits into from
Jun 28, 2022

Conversation

mitgobla
Copy link
Contributor

Filled in many missing documentation descriptions from the behaviour components schema.

  • A few descriptions are based on those from www.bedrock.dev or my own testing/experience
  • A few values were missing minimum/maximum properties and have been added where necessary

Related to issue #15

@DaanV2 DaanV2 changed the title Add many missing documentation to behavior components Add missing documentation to behavior components Jun 24, 2022
@DaanV2 DaanV2 self-requested a review June 24, 2022 17:43
DaanV2
DaanV2 requested changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@DaanV2 DaanV2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thanks for the hard work ☺️ saw a single line that's needs to be checked, and two things I need to confirm in Minecraft, @mitgobla

source/behavior/entities/format/behaviors/harvest_farm_block.json Outdated Show resolved Hide resolved
source/behavior/entities/format/components/block_sensor.json Show resolved Hide resolved
@mitgobla
Correct grammar in harvest block property
0807257 
search_cooldown_max_seconds
@DaanV2 DaanV2 merged commit 0874a22 into Blockception:main Jun 28, 2022
@mitgobla mitgobla deleted the entity-event-documentation branch July 4, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanV2 DaanV2 DaanV2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitgobla @DaanV2