Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Add block sounds enum and remove default texture value under material instance #293

Merged
merged 2 commits into from
Jun 17, 2024
Merged

- Add block sounds enum and remove default texture value under material instance #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09bc210
Update material_instances.json
Xterionix Jun 14, 2024
f1c8557
- Add block sounds enum
Xterionix Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion source/behavior/blocks/format/components/material_instances.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"texture": {
"title": "Texture",
"type": "string",
"default": "",
"description": "Texture name for the material."
}
}
Expand Down
107 changes: 105 additions & 2 deletions source/resource/blocks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,111 @@
}
]
},
"sound": { "type": "string", "title": "Sound", "description": "The sound definition of this block." },
"textures": { "$ref": "#/definitions/texture", "title": "Sound", "description": "Textures." }
"sound": {
"type": "string",
"title": "Sound",
"description": "The sound definition of this block.",
"enum": [
"amethyst_block",
"amethyst_cluster",
"ancient_debris",
"anvil",
"azalea",
"azalea_leaves",
"bamboo",
"bamboo_sapling",
"bamboo_wood",
"bamboo_wood_hanging_sign",
"basalt",
"big_dripleaf",
"bone_block",
"calcite",
"candle",
"cave_vines",
"chain",
"cherry_leaves",
"cherry_wood",
"cherry_wood_hanging_sign",
"chiseled_bookshelf",
"cloth",
"comparator",
"copper",
"copper_bulb",
"copper_grate",
"coral",
"decorated_pot",
"deepslate",
"deepslate_bricks",
"dirt_with_roots",
"dripstone_block",
"frog_spawn",
"froglight",
"fungus",
"glass",
"grass",
"gravel",
"hanging_roots",
"hanging_sign",
"heavy_core",
"honey_block",
"itemframe",
"ladder",
"lantern",
"large_amethyst_bud",
"lever",
"lodestone",
"mangrove_roots",
"medium_amethyst_bud",
"metal",
"moss_block",
"moss_carpet",
"mud",
"mud_bricks",
"muddy_mangrove_roots",
"nether_brick",
"nether_gold_ore",
"nether_sprouts",
"nether_wart",
"nether_wood",
"nether_wood_hanging_sign",
"netherite",
"netherrack",
"nylium",
"packed_mud",
"pink_petals",
"pointed_dripstone",
"polished_tuff",
"powder_snow",
"roots",
"sand",
"scaffolding",
"sculk",
"sculk_catalyst",
"sculk_sensor",
"sculk_shrieker",
"sculk_vein",
"shroomlight",
"slime",
"small_amethyst_bud",
"snow",
"soul_sand",
"soul_soil",
"spore_blossom",
"stem",
"stone",
"suspicious_gravel",
"suspicious_sand",
"sweet_berry_bush",
"trial_spawner",
"tuff",
"tuff_bricks",
"vault",
"vines",
"web",
"wood"
]
Comment on lines +94 to +192
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry cant have this as an enum as its able to have custom enums, this should be done through the json path completion in the vscode extension ☺️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can only use the vanilla block values and these are it. Are you saying you can use custom ones?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thaught so 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure you can't

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's limited to vanilla sounds unfortunately

},
"textures": { "$ref": "#/definitions/texture", "title": "Textures", "description": "Textures." }
}
}
}
Loading