Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc entity fixes #248

Merged
merged 6 commits into from
Mar 23, 2024
Merged

Misc entity fixes #248

merged 6 commits into from
Mar 23, 2024

Conversation

Xterionix
Copy link
Contributor

Resolve #236
Resolve #237
Resolve #238
Resolve #239
Resolve #240
Resolve #241
Resolve #242
Resolve #243
Resolve #244
Resolve #245
Resolve #246
Resolve #247

DaanV2
DaanV2 requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@DaanV2 DaanV2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great picking these up! :)

But some of them I want to be a little stricter on what to enforce or accept as what should the specification

source/behavior/entities/format/behaviors/dig.json Outdated Show resolved Hide resolved
source/behavior/entities/format/components/entity_sensor.json Outdated Show resolved Hide resolved
source/behavior/entities/format/components/follow_range.json Outdated Show resolved Hide resolved
source/behavior/entities/format/components/projectile.json Outdated Show resolved Hide resolved
source/behavior/entities/format/components/projectile.json Outdated Show resolved Hide resolved
source/behavior/entities/format/components/projectile.json Outdated Show resolved Hide resolved
@Xterionix
Copy link
Contributor Author

Alr should be done now

DaanV2
DaanV2 approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@DaanV2 DaanV2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DaanV2 DaanV2 merged commit 7982212 into Blockception:main Mar 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanV2 DaanV2 DaanV2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Xterionix @DaanV2