Update attachables.json added improved documentation of sound_effects + fixed a bug. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update attachables.json and add improved documentation of sound_effects. Fixed a bug where the data type was an array and it should have been an object causing it to be invalid when added.
DaanV2
requested changes
Jan 3, 2024
{
"sound_effects":{
"type":"object",
"minProperties":1,
"additionalProperties":{
"type":"string",
"description":"A single sound effect reference.",
"title":"Sound Effects"
},
"description":"A collection of sound effect references.",
"title":"Sound Effects"
}
}
This is what's changed incase someone wants to fix it before I get the time to do so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update attachables.json and add improved documentation of sound_effects.
Fixed a bug where the data type was an array and it should have been an object causing it to be invalid when added.