Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate item and terrain atlas data #193

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Separate item and terrain atlas data #193

merged 1 commit into from
Dec 9, 2024

Conversation

Xterionix
Copy link
Contributor

@Xterionix
Copy link
Contributor Author

I'm unsure on the find() function; I've made it return itemTextures, if that fails, then terrainTextures and then fallback to textures.

DaanV2
DaanV2 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@DaanV2 DaanV2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Wonderfull!

@DaanV2
Copy link
Contributor

DaanV2 commented Dec 9, 2024

I'm unsure on the find() function; I've made it return itemTextures, if that fails, then terrainTextures and then fallback to textures.

The find function is more meant for just checking if something exists for example :) should be fine

@DaanV2 DaanV2 merged commit b5582d8 into Blockception:main Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanV2 DaanV2 DaanV2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xterionix @DaanV2