Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade targetSDK to API 28 and support libraries to 28.0.0 #39

Merged
merged 7 commits into from
Nov 5, 2018

Conversation

Daniel-Wang
Copy link
Contributor

Features

  • Upgrades the target SDK to API 28 (Pie)
  • Upgrades support library to its final version 28.0.0. The future will be on AndroidX
  • Upgrade constraint layout version to 1.3.3

@Daniel-Wang Daniel-Wang changed the title Upgrade support28 Upgrade targetSDK to API 28 and support libraries to 28.0.0 Oct 4, 2018
@Daniel-Wang
Copy link
Contributor Author

@MeghaBambra Just an update on my trials and successes 😛
Was able to fix a bug that gave me a heart attack, the error looked very similar to the API 19 incompatible algorithm bug. But after carefully googling and stackoverflowing, I found this issue here. And now it works on API 19+. Probably going to file a PR for the README of soneso because of this.
Also, I can't test horizon stuff because wifi is not available on emulators until API 25. But the UI components seem to not crash, which is what I was worried about for this upgrade.

@dabitdev
Copy link
Collaborator

dabitdev commented Nov 2, 2018

Hey Daniel I am getting

Execution failed for task ':app:mergeDebugResources'.
> java.util.concurrent.ExecutionException: com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource compilation failed
  Output:  /Users/David/Projects/stellar-android-wallet/app/build/intermediates/incremental/mergeDebugResources/merged.dir/values/values.xml:1269: error: duplicate value for resource 'attr/strokeColor' with config ''.
  /Users/David/Projects/stellar-android-wallet/app/build/intermediates/incremental/mergeDebugResources/merged.dir/values/values.xml:1269: error: resource previously defined here.

Did you experience any similar issue?

@dabitdev dabitdev merged commit 88c80f6 into dev Nov 5, 2018
@Daniel-Wang Daniel-Wang deleted the upgradeSupport28 branch November 13, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants