Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dissect: add module packages #4361

Merged
merged 1 commit into from
Nov 24, 2024
Merged

dissect: add module packages #4361

merged 1 commit into from
Nov 24, 2024

Conversation

D3vil0p3r
Copy link
Contributor

Close #3688

@D3vil0p3r D3vil0p3r marked this pull request as ready for review November 18, 2024 15:14
@D3vil0p3r D3vil0p3r mentioned this pull request Nov 18, 2024
Copy link
Contributor

@noraj noraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of work. I don't have time to test this right now. At a glance I can see license identifiers are old, could you upgrade to SPDX identifier please?

I hope in the long run that won't turn to be a hell to maintain and that we won't need to switch to virtualenv.

@D3vil0p3r
Copy link
Contributor Author

Licenses upgraded. I did basic tests on all of them during packaging and they worked correctly.

@D3vil0p3r D3vil0p3r requested a review from noraj November 19, 2024 19:51
@noraj
Copy link
Contributor

noraj commented Nov 19, 2024

Licenses upgraded. I did basic tests on all of them during packaging and they worked correctly.

Yes but it will be soon obsolete when AL RFC-0016 will be finalised.

https://wiki.archlinux.org/title/PKGBUILD#license

Note: Arch Linux is currently undergoing a transition to SPDX style identifiers. Some issues may still require ironing out. This section focuses on the SPDX format. If you encounter any trouble, please report them and discuss with the community.

@D3vil0p3r
Copy link
Contributor Author

At least we can manage that massive license change by 1 or 2 sed commands. Btw thanks for the last link.

Copy link
Contributor

@noptrix noptrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, also check, if something is being compiled use arch=('x86_64' 'aarch64') otherwise you can leave arch=('any')

packages/python-acquire/PKGBUILD Outdated Show resolved Hide resolved
packages/python-acquire/PKGBUILD Outdated Show resolved Hide resolved
@noptrix noptrix merged commit a754882 into BlackArch:master Nov 24, 2024
2 checks passed
@D3vil0p3r D3vil0p3r deleted the patch-10 branch November 24, 2024 15:11
@noptrix
Copy link
Contributor

noptrix commented Nov 24, 2024

@D3vil0p3r wrong arch setups :/ i've fixed them - please check my last commits for dissect. again, as soon as something gets compiled to a binary, we need to use ('x86_64', 'aarch64'), otherwise leave as ('any')

@D3vil0p3r
Copy link
Contributor Author

Sorry @noptrix during the building of them I noted that it produced bdist-x86_64 strings.. so I assumed all of them needed ('x86_64', 'aarch64'). How did you check that, instead, any was needed for those dissect in the last commits?

@noptrix
Copy link
Contributor

noptrix commented Nov 24, 2024

@D3vil0p3r no worries at all, just for the future... uhm, i am building them and see that nothign gets compiled, no binaries built. maybe there is another way to do that easier...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dissect
3 participants