Skip to content

Commit

Permalink
Add PRODUCT_BOOT_JARS to derive BOOTCLASSPATH
Browse files Browse the repository at this point in the history
- BOOTCLASSPATH now is product-configurable;
- No need to maintain the duplicate values in core/dex_preopt.mk.
- clean up some legacy ALL_PREBUILTs.
Bug: 9990214

Change-Id: Ie3953e66d282e335bb7782b0ebd56102c35ec10e
  • Loading branch information
Ying Wang committed Jul 24, 2013
1 parent 336b06f commit 0650d15
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 14 deletions.
4 changes: 2 additions & 2 deletions core/dex_preopt.mk
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
#
####################################

# TODO: replace it with device's BOOTCLASSPATH
DEXPREOPT_BOOT_JARS := core:conscrypt:okhttp:core-junit:bouncycastle:ext:framework:framework2:telephony-common:voip-common:mms-common:android.policy:services:apache-xml:webviewchromium
DEXPREOPT_BOOT_JARS := $(PRODUCT_BOOT_JARS)
DEXPREOPT_BOOT_JARS_MODULES := $(subst :, ,$(DEXPREOPT_BOOT_JARS))
PRODUCT_BOOTCLASSPATH := $(subst $(space),:,$(foreach m,$(DEXPREOPT_BOOT_JARS_MODULES),/system/framework/$(m).jar))

DEXPREOPT_BUILD_DIR := $(OUT_DIR)
DEXPREOPT_PRODUCT_DIR := $(patsubst $(DEXPREOPT_BUILD_DIR)/%,%,$(PRODUCT_OUT))/dex_bootjars
Expand Down
9 changes: 0 additions & 9 deletions core/legacy_prebuilts.mk
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ GRANDFATHERED_ALL_PREBUILT := \
cdt.bin \
chat-ril \
cpcap-key.kl \
data \
dev \
egl.cfg \
firmware_error.565 \
firmware_install.565 \
Expand All @@ -45,13 +43,11 @@ GRANDFATHERED_ALL_PREBUILT := \
gps.stingray.so \
gralloc.omap3.so \
gralloc.tegra.so \
hosts \
hwcomposer.tegra.so \
ime \
init.goldfish.rc \
init.goldfish.sh \
init.olympus.rc \
init.rc \
init.sholes.rc \
init.stingray.rc \
input \
Expand All @@ -76,23 +72,18 @@ GRANDFATHERED_ALL_PREBUILT := \
pm \
pppd-ril \
pppd-ril.options \
proc \
qwerty.kl \
radio.img \
rdl.bin \
RFFspeed_501.bmd \
RFFstd_501.bmd \
savebpver \
sbin \
sholes-keypad.kl \
suplcerts.bks \
svc \
sys \
system \
tcmd \
ueventd.goldfish.rc \
ueventd.olympus.rc \
ueventd.rc \
ueventd.stingray.rc \
vold.fstab \
wl1271.bin
4 changes: 3 additions & 1 deletion core/product.mk
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ _product_var_list := \
PRODUCT_VENDOR_KERNEL_HEADERS \
PRODUCT_FACTORY_RAMDISK_MODULES \
PRODUCT_FACTORY_BUNDLE_MODULES \
PRODUCT_RUNTIMES
PRODUCT_RUNTIMES \
PRODUCT_BOOT_JARS


define dump-product
Expand Down Expand Up @@ -208,6 +209,7 @@ endef


_product_stash_var_list := $(_product_var_list) \
PRODUCT_BOOTCLASSPATH \
TARGET_ARCH \
TARGET_ARCH_VARIANT \
TARGET_CPU_VARIANT \
Expand Down
3 changes: 3 additions & 0 deletions core/product_config.mk
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,9 @@ PRODUCT_RUNTIMES := $(product_runtimes)
product_runtimes :=
#############################################################################

# A list of module names of BOOTCLASSPATH (jar files)
PRODUCT_BOOT_JARS := $(PRODUCTS.$(INTERNAL_PRODUCT).PRODUCT_BOOT_JARS)

# Find the device that this product maps to.
TARGET_DEVICE := $(PRODUCTS.$(INTERNAL_PRODUCT).PRODUCT_DEVICE)

Expand Down
1 change: 0 additions & 1 deletion target/board/vbox_x86/BoardConfig.mk
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ TARGET_NO_RECOVERY := true
TARGET_HARDWARE_3D := false
BOARD_USES_GENERIC_AUDIO := true
USE_CAMERA_STUB := true
TARGET_PROVIDES_INIT_RC := true
TARGET_CPU_ABI := x86
TARGET_USERIMAGES_USE_EXT4 := true
TARGET_BOOTIMAGE_USE_EXT2 := true
Expand Down
1 change: 0 additions & 1 deletion target/board/vbox_x86/device.mk
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ PRODUCT_COPY_FILES := \
device/generic/goldfish/data/etc/apns-conf.xml:system/etc/apns-conf.xml \
device/generic/goldfish/camera/media_profiles.xml:system/etc/media_profiles.xml \
device/generic/goldfish/camera/media_codecs.xml:system/etc/media_codecs.xml \
system/core/rootdir/init.rc:root/init.rc \
build/target/board/vbox_x86/init.vbox_x86.rc:root/init.vbox_x86.rc \
$(LOCAL_KERNEL):kernel

Expand Down
3 changes: 3 additions & 0 deletions target/product/core.mk
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,6 @@ PRODUCT_PACKAGES += \
voip-common

$(call inherit-product, $(SRC_TARGET_DIR)/product/core_minimal.mk)

# Override the PRODUCT_BOOT_JARS set in core_minimal.mk
PRODUCT_BOOT_JARS := core:conscrypt:okhttp:core-junit:bouncycastle:ext:framework:framework2:telephony-common:voip-common:mms-common:android.policy:services:apache-xml:webviewchromium
2 changes: 2 additions & 0 deletions target/product/core_minimal.mk
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ PRODUCT_PACKAGES += \
sensorservice \
uiautomator

PRODUCT_BOOT_JARS := core:conscrypt:okhttp:core-junit:bouncycastle:ext:framework:framework2:android.policy:services:apache-xml:webviewchromium

PRODUCT_RUNTIMES := runtime_libdvm_default
ifneq (,$(filter userdebug eng, $(TARGET_BUILD_VARIANT)))
PRODUCT_RUNTIMES += runtime_libart
Expand Down
5 changes: 5 additions & 0 deletions target/product/embedded.mk
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ PRODUCT_PACKAGES += \
gralloc.default \
gzip \
init \
init.environ.rc \
init.rc \
input \
libEGL \
libETC1 \
Expand Down Expand Up @@ -72,6 +74,9 @@ PRODUCT_PACKAGES += \
property_contexts \
mac_permissions.xml


PRODUCT_COPY_FILES += \
system/core/rootdir/init.usb.rc:root/init.usb.rc \
system/core/rootdir/init.trace.rc:root/init.trace.rc \
system/core/rootdir/ueventd.rc:root/ueventd.rc \
system/core/rootdir/etc/hosts:system/etc/hosts

0 comments on commit 0650d15

Please sign in to comment.