Fix for the once event listener not removing the correct handler func…

…tion
Bizboard · Oct 7, 2015 · ee4f0a1 · ee4f0a1
1 parent af4951b
commit ee4f0a1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/core/PrioritisedArray.js b/src/core/PrioritisedArray.js
@@ -98,11 +98,11 @@ export class PrioritisedArray extends Array {
      * @returns {void}
      */
     once(event, handler, context = this) {
-        return this.on(event, function () {
+        return this.on(event, function onceWrapper() {
             /* TODO: bug in traceur preventing us from using ...arguments as expected: https://github.com/google/traceur-compiler/issues/1118
              * We want to do this: handler.call(context, ...arguments); */
             handler.call(context, arguments);
-            this.off(event, handler, context);
+            this.off(event, onceWrapper, context);
         }, this);
     }
 

diff --git a/src/core/PrioritisedObject.js b/src/core/PrioritisedObject.js
@@ -94,9 +94,11 @@ export class PrioritisedObject extends EventEmitter {
      * @returns {void}
      */
     once(event, handler, context = this) {
-        return this.on(event, function () {
+        return this.on(event, function onceWrapper() {
+            /* TODO: bug in traceur preventing us from using ...arguments as expected: https://github.com/google/traceur-compiler/issues/1118
+             * We want to do this: handler.call(context, ...arguments); */
             handler.call(context, arguments);
-            this.off(event, handler, context);
+            this.off(event, onceWrapper, context);
         }, this);
     }