Skip to content

Commit

Permalink
Removed child value emit for now, since it introduced a race conditio…
Browse files Browse the repository at this point in the history
…n where prioObjects would overwrite their local IDs with their remote counterparts, breaking prioArray child_changed events.
  • Loading branch information
tjclement committed Dec 2, 2015
1 parent dc2687a commit 26e3b94
Show file tree
Hide file tree
Showing 3 changed files with 12,185 additions and 12,189 deletions.
3 changes: 2 additions & 1 deletion Worker/SharePointClient.js
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,8 @@ export class SharePointClient extends EventEmitter {
model.id = model['_temporary-identifier'] || model.id;
model.remoteId = remoteId;
if (this.isChild) {
this.emit('message', {event: 'value', result: model});
/* TODO: re-enable value emit on children when child subscriptions are implemented */
//this.emit('message', {event: 'value', result: model});
} else {
this.emit('message', {event: 'child_changed', result: model});
this.emit('message', {event: 'value', result: this.cache});
Expand Down
Loading

0 comments on commit 26e3b94

Please sign in to comment.