Replace 'Drain' with 'Change' for clearer terminology #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkciw
reviewed
Oct 4, 2024
| /// Minimum value allowed for a drain (change) output. | ||
| pub min_drain_value: u64, | ||
| /// Minimum value allowed for a change output. | ||
| pub min_change_value: u64, | ||
|
|
||
| /// Strategy to use the excess value other than fee and target | ||
| pub excess_strategy: ExcessStrategy, |
There was a problem hiding this comment.
#54
Please replace ToDrain in excess strategy with ToChange
pub enum ExcessStrategy {
ToFee,
ToRecipient,
ToDrain,
}
jkciw
reviewed
Oct 4, 2024
| @@ -672,7 +672,7 @@ fn calculate_waste( | |||
| waste += (accumulated_value - (options.target_value + estimated_fee)); | |||
There was a problem hiding this comment.
#54 Please change this reference to ToDrain
if options.excess_strategy != ExcessStrategy::ToDrain {
// Change is not created if excess strategy is ToFee or ToRecipient. Hence cost of change is added
waste += (accumulated_value - (options.target_value + estimated_fee));
} else {
jkciw
reviewed
Oct 4, 2024
src/lib.rs
Outdated
Comment on lines
859
to
861
| min_change_value: 500, | ||
| excess_strategy: ExcessStrategy::ToDrain, | ||
| } |
There was a problem hiding this comment.
/ #54 Please change ToDrain
jkciw
reviewed
Oct 4, 2024
src/lib.rs
Outdated
| cost_per_input: 20, | ||
| cost_per_output: 10, | ||
| min_drain_value, | ||
| min_change_value, | ||
| excess_strategy: ExcessStrategy::ToDrain, |
jkciw
reviewed
Oct 4, 2024
src/lib.rs
Outdated
| cost_per_input: 20, | ||
| cost_per_output: 10, | ||
| min_drain_value: 500, | ||
| min_change_value: 500, | ||
| excess_strategy: ExcessStrategy::ToDrain, |
There was a problem hiding this comment.
Thank you for the feedback!
delcin-raj
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52