Update FIFO selection to prioritize OutputGroups with None sequence #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delcin-raj
requested changes
Aug 28, 2024
src/lib.rs
Outdated
|
|
||
| sorted_inputs.sort_by_key(|(_, a)| a.creation_sequence); | ||
| let mut sorted_inputs = Vec::new(); |
There was a problem hiding this comment.
Don't create this variable
|
|
||
| let mut sorted_inputs: Vec<_> = inputs.iter().enumerate().collect(); | ||
| let mut inputs_without_sequence: Vec<_> = inputs |
There was a problem hiding this comment.
Extend this with inputs without sequence after sorting
BEULAHEVANJALIN
force-pushed
the
main
branch
2 times, most recently
from
1eb4bbf
to
0dbdc20
Compare
NeoZ666
pushed a commit
to NeoZ666/rust-coinselect
that referenced
this pull request
Sep 16, 2024
…itshala-Incubator#47) * Update FIFO selection to prioritize OutputGroups with None sequence * Prioritize OutputGroups with sequence numbers * Fix Clippy warning by using instead of Signed-off-by: neoz666 <[email protected]>
NeoZ666
pushed a commit
to NeoZ666/rust-coinselect
that referenced
this pull request
Sep 16, 2024
…itshala-Incubator#47) * Update FIFO selection to prioritize OutputGroups with None sequence * Prioritize OutputGroups with sequence numbers * Fix Clippy warning by using instead of Signed-off-by: neoz666 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
select_coin_fifofunction to prioritizeOutputGroups that haveNoneas theircreation_sequence, treating them as the earliest in the selection process. I've also included updates to the test cases to ensure that this behavior is correctly verified.