Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: audit workflow split apart #1397

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

feat: audit workflow split apart #1397

wants to merge 22 commits into from

Conversation

tchalvak
Copy link
Member

@tchalvak tchalvak commented Jan 29, 2023 •
edited
Loading

Purpose of PR:

Before

After

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

@tchalvak tchalvak enabled auto-merge January 29, 2023 02:50
@tchalvak tchalvak changed the title Feat/audit workflow split apart feat: audit workflow split apart Jan 29, 2023
@tchalvak tchalvak force-pushed the feat/audit-workflow-split-apart branch from 9239e6f to 191a5de Compare January 30, 2023 01:17
auto-merge was automatically disabled February 9, 2023 15:25

Merge queue setting changed

@tchalvak tchalvak enabled auto-merge February 28, 2023 06:46
@tchalvak tchalvak force-pushed the feat/audit-workflow-split-apart branch from 7c8bbf7 to 76997f1 Compare March 3, 2023 03:24
tchalvak and others added 20 commits March 2, 2023 22:28
@tchalvak
Add static builds, audit and php build, lighthouse,
806e591 
test for smarty plugin.
@tchalvak
Package.json updates for build and serve static.
90e2b86
@deepsource-autofix @tchalvak
Format code with php-cs-fixer
3550781
@tchalvak
Provide check for database connection.
8db1263
@tchalvak
Update format of class static data.
5831a51
@deepsource-autofix @tchalvak
Format code with php-cs-fixer
a1ae584
@tchalvak
Simplify gitkeep nonremoval while running make clean.
30a7898
@tchalvak
Fix deprecated use of filter constant.
061fff6
@tchalvak
Test filtering fixes.
2d77451
@deepsource-autofix @tchalvak
Format code with php-cs-fixer
4efbcb9
@tchalvak
Update the build to split out the configure step first.
ae97673
@tchalvak
Make changes to php 8.2.
2b68b16
@tchalvak
Fix configure not overriding.
2e722ff
@tchalvak
Deprecation issue fixes,
78ec3bf 
with a new attribute for php 8.2.
@tchalvak
Composer updates.
0596ff5
@tchalvak
One more special property on DAO base class.
4d225b5
@tchalvak
Change message for clarity.
d22cdbe
@tchalvak
Minor comment for php workflow todo for github token.
0f7744b
@tchalvak
makefile cleanup continued.
a5a08ea
@tchalvak
Rollback composer.lock to master.
845e010
@tchalvak tchalvak force-pushed the feat/audit-workflow-split-apart branch from 76997f1 to 845e010 Compare March 3, 2023 03:28
auto-merge was automatically disabled March 3, 2023 06:05

Merge queue setting changed

@tchalvak tchalvak mentioned this pull request Mar 21, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tchalvak