Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add static build of intro and index, audit github action. #1160

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

tchalvak
Copy link
Member

@tchalvak tchalvak commented Jan 4, 2022

Purpose of PR:

Speculatively add github action.

TODO:

  • remove login and signup controllers here

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a player
  • This will fix a bug

Preview results in my branch at the url:

@tchalvak tchalvak force-pushed the feature/action-for-audit-yml branch from c2d3def to b0e4be3 Compare January 4, 2022 18:21
@tchalvak tchalvak changed the title Add audit github action. Add static build of intro and index, audit github action. Jan 10, 2022
@tchalvak
Copy link
Member Author

I want to add the static build to allow for static e2e testing as well.

@tchalvak
Copy link
Member Author

tchalvak commented Jan 10, 2022

  • Consider adding static builds of login and signup pages as well.

@tchalvak tchalvak changed the title Add static build of intro and index, audit github action. feat: add static build of intro and index, audit github action. Jan 15, 2022
@tchalvak tchalvak changed the title feat: add static build of intro and index, audit github action. perf: add static build of intro and index, audit github action. Jan 15, 2022
@tchalvak tchalvak force-pushed the feature/action-for-audit-yml branch from 3efed05 to 1e1ed32 Compare July 19, 2022 22:20
@tchalvak tchalvak added the hold label Nov 10, 2022
@tchalvak tchalvak marked this pull request as draft March 21, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant