Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy): implement custom proxy agent support in BitGoAPI #5200

Closed
wants to merge 1 commit into from

Conversation

ayush-9
Copy link
Contributor

@ayush-9 ayush-9 commented Dec 3, 2024

TICKET: CE-4801

BREAKING CHANGE

  • Instead of getting the proxy url, now he caller should just pass in an instance of the proxy-agent they wish to use in the sdk-api, using a new param named customProxyAgent
  • Making bitgo/express pass in the proxy agent by default

@ayush-9 ayush-9 force-pushed the CE-4801 branch 3 times, most recently from 65d03da to 1c8d01c Compare December 3, 2024 11:20
@ayush-9 ayush-9 marked this pull request as ready for review December 3, 2024 15:52
@ayush-9 ayush-9 requested review from a team as code owners December 3, 2024 15:52
@@ -1,5 +1,6 @@
import { EnvironmentName, IRequestTracer, V1Network } from '@bitgo/sdk-core';
import { ECPairInterface } from '@bitgo/utxo-lib';
import { Agent } from 'http';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import as type

Copy link
Contributor

@bitgoAaron bitgoAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please import as type where appropriate to avoid clients having to parse the type

@ayush-9 ayush-9 closed this Dec 3, 2024
@ayush-9
Copy link
Contributor Author

ayush-9 commented Dec 3, 2024

closing this pr as the github is not able to load changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants