Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-coin-apt): add wallet and address support #5168

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

baltiyal
Copy link
Contributor

@baltiyal baltiyal commented Nov 25, 2024

TICKET: COIN-2362
For Aptos Coin, the changes needed to support the validation and creation of Wallet and Address in Platform.

@baltiyal baltiyal requested review from a team as code owners November 25, 2024 12:09
@baltiyal baltiyal merged commit 3357a62 into master Nov 25, 2024
9 checks passed
Comment on lines +70 to +77
async isWalletAddress(params: VerifyAddressOptions): Promise<boolean> {
const { address: newAddress } = params;

if (!this.isValidAddress(newAddress)) {
throw new InvalidAddressError(`invalid address: ${newAddress}`);
}
return true;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this method supposed to ensure that the address is an actual wallet address as opposed to an arbitrary address?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants