feat(sdk-coin-oas): add oas sdk skeleton #5093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
adarsh312
force-pushed
the
WIN-3696_oas_skeleton
branch
from
31c091c to
d0a57b1
Compare
adarsh312
force-pushed
the
WIN-3696_oas_skeleton
branch
3 times, most recently
from
12fcdf0 to
e22f195
Compare
modules/sdk-coin-oas/src/oas.ts
Outdated
| /** @inheritDoc */ | ||
| allowsAccountConsolidations(): boolean { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
This is not needed as it is having forwarders
There was a problem hiding this comment.
no need to add this method only as by default it is false in the BaseCoin, can remove in a follow up
adarsh312
force-pushed
the
WIN-3696_oas_skeleton
branch
2 times, most recently
from
18393d7 to
73658c0
Compare
gianchandania
previously approved these changes
Nov 13, 2024
modules/sdk-coin-oas/src/oas.ts
Outdated
| /** @inheritDoc */ | ||
| allowsAccountConsolidations(): boolean { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
no need to add this method only as by default it is false in the BaseCoin, can remove in a follow up
zahin-mohammad
previously requested changes
Nov 13, 2024
| @@ -0,0 +1,106 @@ | |||
| export const keyShares = { | |||
There was a problem hiding this comment.
This looks like a GG18 keyshare. Can we convert this test to use DKLS instead?
adarsh312
force-pushed
the
WIN-3696_oas_skeleton
branch
2 times, most recently
from
68a3f97 to
7cb1a1d
Compare
| export class TransactionBuilder extends AbstractTransactionBuilder { | ||
| amount(arg0: number) { | ||
| throw new Error('Method not implemented.'); | ||
| } |
There was a problem hiding this comment.
this amount method seems like a mistake, please remove it
adarsh312
force-pushed
the
WIN-3696_oas_skeleton
branch
from
7cb1a1d to
f158abc
Compare
adarsh312
force-pushed
the
WIN-3696_oas_skeleton
branch
from
f158abc to
db07361
Compare
adarsh312
force-pushed
the
WIN-3696_oas_skeleton
branch
from
db07361 to
d04f601
Compare
gianchandania
approved these changes
Nov 14, 2024
adarsh312
dismissed
zahin-mohammad’s stale review
required changes are completed and reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-3696