feat(sdk-coin-atom): add sendMany support #3965
Conversation
dpkjnr
force-pushed
the
cosmos-sendmany
branch
from
939e95e to
5570298
Compare
| @@ -268,7 +268,7 @@ describe('Zeta', function () { | |||
| amount: 'UNAVAILABLE', | |||
| }, | |||
| ], | |||
| outputAmount: 'UNAVAILABLE', | |||
There was a problem hiding this comment.
any specific reason why we changed this ?
There was a problem hiding this comment.
I didn't see any usage of it and made is same as atom
|
|
||
| const tx = await txBuilder.build(); | ||
| const json = await (await txBuilder.build()).toJson(); | ||
| should.equal(tx.type, TransactionType.Send); |
There was a problem hiding this comment.
Ideally we'd need this test for the other supported transaction types too
| amount: UNAVAILABLE_TEXT, | ||
| }, | ||
| ]; | ||
| outputAmount = UNAVAILABLE_TEXT; |
There was a problem hiding this comment.
was this intentionally removed ?
There was a problem hiding this comment.
yes, to make is similar to atom. I also checked that it is not being used anywhere
| amount: [ | ||
| { | ||
| denom: 'uatom', | ||
| amount: '500', |
There was a problem hiding this comment.
nit: can we use a txn with different amounts for the two recipients.
There was a problem hiding this comment.
doing it for delegate and undelegate txns
| @@ -209,6 +232,31 @@ describe('ATOM', function () { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should explain sendMany transfer transaction', async function () { | |||
There was a problem hiding this comment.
can we add one testcase for sendMany delegate and undelegate transfer type also.
There was a problem hiding this comment.
same for any abstract-cosmos coin also.
| amount: [ | ||
| { | ||
| denom: 'utia', | ||
| amount: '100000', |
There was a problem hiding this comment.
same here, can we use different amounts.
dpkjnr
force-pushed
the
cosmos-sendmany
branch
from
5570298 to
ee609ec
Compare
dpkjnr
requested review from
mullapudipruthvik,
Vijay-Jagannathan and
DinshawKothari
There was a problem hiding this comment.
LGTM @DinshawKothari or @Vijay-Jagannathan can be final approver
Cosmos side chains natively support transactions with multiple recipients. This PR adds test cases to verify multiple recipient transaction building and fixes explain transaction code to generate input and outputs for all recipients.
Added tests only for Atom and Tia as Atom doesn't extend common cosmos classes, and adding tests for any one of other coins that extend cosmos base classes would suffice
Ticket: WIN-17