merge master into staging-ln #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mentioned PR was merged and we can move back to upstream.
Move `signProgress` into the `ConfirmingWaitDialog` and `BB02ConfirmSend` sub-components of the `ConfirmSend` sub-component in `send.tsx`. This simplifies the `Send` component and makes it easier to understand. Also rename `signProgress` API subscription function to `syncSignProgress` for a better diff and to avoid confusion with state in the component.
Right now the `BB02ConfirmSend` component subscribes to the `signProgress` event. This event **can only be fired** if a BB01 is connected: 8e307af it is not fired if a BB02 is connected (searched the backend for `EventSignProgress` it is only in the BB01 impl.). Because the component is only shown if the connected device is `bitbox02`, the state is always `undefined` and can be removed.
…s-to-sub-component'
- Bundle identifier: swiss.bitbox.BitBoxAppTestnet - Product name: BitBoxApp Testnet The reason for this is so that we can push a testnet app to testflight for internal testing. The new target has a `TARGET_TESTNET` definition set, which is used to change the testnet argument when launching the backend.
The iOS app currently can't connect to a BitBox. In the testnet app target, we enable the software keystore for now, which we can use to load accounts to test the app already now. This is supposed to be temporary - we might enable another way to load the software keystore in general later, but should disable it for general use once a BitBox is able to connect.
To prevent USB communication interruptions when e.g. recovering from 24 words. See BitBoxSwiss/bitbox02-api-go#111 ``` go get github.com/BitBoxSwiss/bitbox02-api-go@a2115fe go mod tidy go mod vendor ```
To not confuse it with the main app. Generated by ChatGPT/Dalle. We can replace it with something better later.
Needed for QR code scanning. WebView in addition has a permission request that can answered with "prompt" or "grant". We grant by default, as the permission was already granted at install time, and our WebView is not a general browser where giving permission on a per-page basis is that useful. We could consider turning it into a prompt when the request comes from an exchange widget in the future.
See comment inside the commit. Somehow the full screen video element behaves completely differently than the inline one. The inline one behaves like on Android and Qt.
Previously, log export button was hidden on Android, but the functionality actually works. This commit enabled it.
With different translations the action buttons (send, receive, buy & sell and WC) did not break nicely on small screen. Due to limited button height the text could be outside of the button and only visible in darkmode but not in normal mode (white on gray). Changed to let the buttons break onto 2 lines of text if there is not enough horozontal space.
Also remove unused "button.buy" locize label.
Merged
shonsirsha
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No conflicts