-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OP-351 - Update builds #505
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7c7654a
OP-351 - Update builds
ed4230c
OP-351 - Update conding standard build, add on push event
3d94229
OP-351 - Rename phpstan configuration file
f49ba9d
OP-351 - Update coding standards build file
cb7969e
OP-351 - Enable coding standard on push
SzymonKostrubiec 657f0c0
OP-351 - Apply changes from bitbag bible
SzymonKostrubiec 37f5ea7
OP-351 - CR fixes, add PHP 8.0 check rule for Sylius 1.12 on symfony 5.4
SzymonKostrubiec 40ac776
OP-351 - Add phpUnit dependency to fix builds on Sylius 1.12 with PHP…
SzymonKostrubiec 5051cf2
OP-351 - Add matthiasnoback dependency to fix builds on Sylius 1.12 w…
SzymonKostrubiec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,13 @@ | ||
name: Build | ||
|
||
on: | ||
push: | ||
branches-ignore: | ||
- 'dependabot/**' | ||
pull_request: ~ | ||
release: | ||
types: [created] | ||
types: [ created ] | ||
schedule: | ||
- | ||
cron: "0 1 * * 6" # Run at 1am every Saturday | ||
- cron: "0 1 * * 6" | ||
workflow_dispatch: ~ | ||
|
||
jobs: | ||
|
@@ -21,160 +19,133 @@ jobs: | |
strategy: | ||
fail-fast: false | ||
matrix: | ||
php: ["8.1", "8.2", "8.3"] | ||
symfony: ["^5.4", "^6.4"] | ||
sylius: ["~1.12.0", "~1.13.0"] | ||
node: ["18.x", "20.x"] | ||
mysql: ["8.0"] | ||
php: [ "8.1", "8.2", "8.3" ] | ||
symfony: [ "^5.4", "^6.4" ] | ||
sylius: [ "^1.12", "^1.13" ] | ||
node: [ "18.x", "20.x" ] | ||
mysql: [ "8.0" ] | ||
|
||
env: | ||
APP_ENV: test | ||
DATABASE_URL: "mysql://root:[email protected]/sylius?serverVersion=${{ matrix.mysql }}" | ||
|
||
steps: | ||
- | ||
uses: actions/checkout@v3 | ||
- uses: actions/checkout@v3 | ||
|
||
- | ||
name: Setup PHP | ||
- name: Setup PHP | ||
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: "${{ matrix.php }}" | ||
extensions: intl | ||
tools: flex, symfony | ||
coverage: none | ||
|
||
- | ||
name: Setup Node | ||
- name: Setup Node | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: "${{ matrix.node }}" | ||
|
||
- | ||
name: Shutdown default MySQL | ||
- name: Shutdown default MySQL | ||
run: sudo service mysql stop | ||
|
||
- | ||
name: Setup MySQL | ||
- name: Setup MySQL | ||
uses: mirromutth/[email protected] | ||
with: | ||
mysql version: "${{ matrix.mysql }}" | ||
mysql root password: "root" | ||
|
||
- | ||
name: Output PHP version for Symfony CLI | ||
- name: Output PHP version for Symfony CLI | ||
run: php -v | head -n 1 | awk '{ print $2 }' > .php-version | ||
|
||
- | ||
name: Install certificates | ||
- name: Install certificates | ||
run: symfony server:ca:install | ||
|
||
- name: Run Chrome Headless | ||
run: google-chrome-stable --enable-automation --disable-background-networking --no-default-browser-check --no-first-run --disable-popup-blocking --disable-default-apps --allow-insecure-localhost --disable-translate --disable-extensions --no-sandbox --enable-features=Metal --headless --remote-debugging-port=9222 --window-size=2880,1800 --proxy-server='direct://' --proxy-bypass-list='*' http://127.0.0.1 > /dev/null 2>&1 & | ||
|
||
- | ||
name: Run webserver | ||
- name: Run webserver | ||
run: (cd tests/Application && symfony server:start --port=8080 --dir=public --daemon) | ||
|
||
- | ||
name: Get Composer cache directory | ||
- name: Get Composer cache directory | ||
id: composer-cache | ||
run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT | ||
|
||
- | ||
name: Cache Composer | ||
- name: Cache Composer | ||
uses: actions/cache@v4 | ||
with: | ||
path: ${{ steps.composer-cache.outputs.dir }} | ||
key: ${{ runner.os }}-php-${{ matrix.php }}-composer-${{ hashFiles('**/composer.json **/composer.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-php-${{ matrix.php }}-composer- | ||
|
||
- | ||
name: Restrict Sylius version | ||
- name: Restrict Sylius version | ||
if: matrix.sylius != '' | ||
run: composer require "sylius/sylius:${{ matrix.sylius }}" --no-update --no-scripts --no-interaction | ||
|
||
- | ||
name: Install PHP dependencies | ||
- name: Install PHP dependencies | ||
run: composer install --no-interaction | ||
env: | ||
SYMFONY_REQUIRE: ${{ matrix.symfony }} | ||
SYMFONY_REQUIRE: ${{ matrix.symfony }} | ||
|
||
- | ||
name: Install Behat driver | ||
- name: Install Behat driver | ||
run: vendor/bin/bdi browser:google-chrome drivers | ||
|
||
- | ||
name: Get Yarn cache directory | ||
- name: Get Yarn cache directory | ||
id: yarn-cache | ||
run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT | ||
|
||
- | ||
name: Cache Yarn | ||
- name: Cache Yarn | ||
uses: actions/cache@v4 | ||
with: | ||
path: ${{ steps.yarn-cache.outputs.dir }} | ||
key: ${{ runner.os }}-node-${{ matrix.node }}-yarn-${{ hashFiles('**/package.json **/yarn.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-node-${{ matrix.node }}-yarn- | ||
|
||
- | ||
name: Install JS dependencies | ||
- name: Install JS dependencies | ||
run: | | ||
(cd tests/Application && yarn install) | ||
|
||
- | ||
name: Prepare test application database | ||
- name: Prepare test application database | ||
run: | | ||
(cd tests/Application && bin/console doctrine:database:create -vvv) | ||
(cd tests/Application && bin/console doctrine:migrations:migrate -n -vvv -q) | ||
|
||
- | ||
name: Prepare test application assets | ||
- name: Prepare test application assets | ||
run: | | ||
(cd tests/Application && bin/console assets:install public -vvv) | ||
(cd tests/Application && yarn build:prod) | ||
|
||
- | ||
name: Prepare test application cache | ||
- name: Prepare test application cache | ||
run: (cd tests/Application && bin/console cache:warmup -vvv) | ||
|
||
- | ||
name: Load fixtures in test application | ||
- name: Load fixtures in test application | ||
run: (cd tests/Application && bin/console sylius:fixtures:load -n) | ||
|
||
- | ||
name: Validate composer.json | ||
- name: Validate composer.json | ||
run: composer validate --ansi --strict | ||
|
||
- | ||
name: Validate database schema | ||
- name: Validate database schema | ||
run: (cd tests/Application && bin/console doctrine:schema:validate) | ||
|
||
- | ||
name: Run PHPSpec | ||
- name: Run PHPSpec | ||
run: vendor/bin/phpspec run --ansi -f progress --no-interaction | ||
|
||
- | ||
name: Run PHPUnit | ||
- name: Run PHPUnit | ||
run: vendor/bin/phpunit --colors=always | ||
|
||
- | ||
name: Run Behat | ||
run: vendor/bin/behat --colors --strict -vvv --no-interaction -f progress || vendor/bin/behat --colors --strict -vvv --no-interaction -f progress --rerun | ||
- name: Run Behat | ||
run: vendor/bin/behat --colors --strict -vvv --no-interaction -f progress || vendor/bin/behat --colors --strict -vvv --no-interaction -f progress --rerun | ||
|
||
- | ||
name: Upload Behat logs | ||
- name: Upload Behat logs | ||
uses: actions/upload-artifact@v3 | ||
if: failure() | ||
with: | ||
name: Behat logs | ||
path: etc/build/ | ||
if-no-files-found: ignore | ||
|
||
- | ||
name: Failed build Slack notification | ||
- name: Failed build Slack notification | ||
uses: rtCamp/action-slack-notify@v2 | ||
if: ${{ failure() && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master') }} | ||
env: | ||
|
@@ -184,4 +155,4 @@ jobs: | |
SLACK_MESSAGE: ':x:' | ||
SLACK_TITLE: Failed build on ${{ github.event.repository.name }} repository | ||
SLACK_USERNAME: ${{ secrets.FAILED_BUILD_SLACK_USERNAME }} | ||
SLACK_WEBHOOK: ${{ secrets.FAILED_BUILD_SLACK_WEBHOOK }} | ||
SLACK_WEBHOOK: ${{ secrets.FAILED_BUILD_SLACK_WEBHOOK }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,84 +1,81 @@ | ||
name: Coding standard | ||
|
||
on: | ||
push: | ||
branches-ignore: | ||
- 'dependabot/**' | ||
pull_request: ~ | ||
release: | ||
types: [created] | ||
schedule: | ||
- | ||
cron: "0 1 * * 6" # Run at 1am every Saturday | ||
workflow_dispatch: ~ | ||
push: | ||
branches-ignore: | ||
- 'dependabot/**' | ||
pull_request: ~ | ||
release: | ||
types: [ created ] | ||
workflow_dispatch: ~ | ||
|
||
jobs: | ||
tests: | ||
runs-on: ubuntu-latest | ||
tests: | ||
runs-on: ubuntu-latest | ||
|
||
name: "Sylius ${{ matrix.sylius }}, PHP ${{ matrix.php }}, Symfony ${{ matrix.symfony }}" | ||
name: "Sylius ${{ matrix.sylius }}, PHP ${{ matrix.php }}, Symfony ${{ matrix.symfony }}" | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
php: ["8.1"] | ||
symfony: ["^5.4", "^6.4"] | ||
sylius: ["~1.13.0"] | ||
node: ["20.x"] | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
php: [ "8.1", "8.2", "8.3" ] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sylius 1.12 has PHP ^8.0 rule. |
||
symfony: [ "^5.4", "^6.4" ] | ||
sylius: [ "^1.12", "^1.13" ] | ||
node: [ "18.x", "20.x" ] | ||
|
||
env: | ||
APP_ENV: test | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Setup PHP | ||
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: "${{ matrix.php }}" | ||
extensions: intl | ||
tools: symfony | ||
coverage: none | ||
|
||
- name: Get Composer cache directory | ||
id: composer-cache | ||
run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT | ||
|
||
steps: | ||
- | ||
uses: actions/checkout@v3 | ||
- | ||
name: Setup PHP | ||
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: "${{ matrix.php }}" | ||
extensions: intl | ||
tools: flex, symfony | ||
coverage: none | ||
- | ||
name: Get Composer cache directory | ||
id: composer-cache | ||
run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT | ||
- name: Cache Composer | ||
uses: actions/cache@v4 | ||
with: | ||
path: ${{ steps.composer-cache.outputs.dir }} | ||
key: ${{ runner.os }}-php-${{ matrix.php }}-composer-${{ hashFiles('**/composer.json', '**/composer.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-php-${{ matrix.php }}-composer- | ||
|
||
- | ||
name: Cache Composer | ||
uses: actions/cache@v4 | ||
with: | ||
path: ${{ steps.composer-cache.outputs.dir }} | ||
key: ${{ runner.os }}-php-${{ matrix.php }}-composer-${{ hashFiles('**/composer.json **/composer.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-php-${{ matrix.php }}-composer- | ||
- | ||
name: Restrict Sylius version | ||
if: matrix.sylius != '' | ||
run: composer require "sylius/sylius:${{ matrix.sylius }}" --no-update --no-scripts --no-interaction | ||
- name: Restrict Symfony version | ||
if: matrix.symfony != '' | ||
run: | | ||
composer global config --no-plugins allow-plugins.symfony/flex true | ||
composer global require --no-progress --no-scripts --no-plugins "symfony/flex:^1.10" | ||
composer config extra.symfony.require "${{ matrix.symfony }}" | ||
|
||
- | ||
name: Install PHP dependencies | ||
run: composer install --no-interaction | ||
env: | ||
SYMFONY_REQUIRE: ${{ matrix.symfony }} | ||
- name: Restrict Sylius version | ||
if: matrix.sylius != '' | ||
run: composer require "sylius/sylius:${{ matrix.sylius }}" --no-update --no-scripts --no-interaction | ||
|
||
- | ||
name: Run PHPStan | ||
run: vendor/bin/phpstan analyse | ||
- name: Install PHP dependencies | ||
run: composer install --no-interaction | ||
env: | ||
SYMFONY_REQUIRE: ${{ matrix.symfony }} | ||
|
||
- name: Run PHPStan | ||
run: vendor/bin/phpstan analyse -c phpstan.neon -l 8 src/ | ||
|
||
- name: Run ECS | ||
run: vendor/bin/ecs | ||
- name: Run ECS | ||
run: vendor/bin/ecs | ||
|
||
- name: Failed build Slack notification | ||
uses: rtCamp/action-slack-notify@v2 | ||
if: ${{ failure() && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master') }} | ||
env: | ||
SLACK_CHANNEL: ${{ secrets.FAILED_BUILD_SLACK_CHANNEL }} | ||
SLACK_COLOR: ${{ job.status }} | ||
SLACK_ICON: https://github.com/rtCamp.png?size=48 | ||
SLACK_MESSAGE: ':x:' | ||
SLACK_TITLE: Failed build on ${{ github.event.repository.name }} repository | ||
SLACK_USERNAME: ${{ secrets.FAILED_BUILD_SLACK_USERNAME }} | ||
SLACK_WEBHOOK: ${{ secrets.FAILED_BUILD_SLACK_WEBHOOK }} | ||
- name: Failed build Slack notification | ||
uses: rtCamp/action-slack-notify@v2 | ||
if: ${{ failure() && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master') }} | ||
env: | ||
SLACK_CHANNEL: ${{ secrets.FAILED_BUILD_SLACK_CHANNEL }} | ||
SLACK_COLOR: ${{ job.status }} | ||
SLACK_ICON: https://github.com/rtCamp.png?size=48 | ||
SLACK_MESSAGE: ':x:' | ||
SLACK_TITLE: Failed build on ${{ github.event.repository.name }} repository | ||
SLACK_USERNAME: ${{ secrets.FAILED_BUILD_SLACK_USERNAME }} | ||
SLACK_WEBHOOK: ${{ secrets.FAILED_BUILD_SLACK_WEBHOOK }} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure whether this should be done like this. The phpstan.neon seems to be a local file like .env.local. |
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sylius 1.12 has PHP ^8.0 rule.