OP-320: Add possibility to select section type and fill up collection of items of this type #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkindly
commented
Jun 19, 2024
jkindly
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | OP-320, OP-312 |
| License | MIT |
… of items of this type
senghe
requested changes
Jun 20, 2024
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| <field name="publishAt" column="publish_at" type="datetime_immutable" nullable="true"/> | |||
|
|
|||
| <many-to-many field="sections" target-entity="BitBag\SyliusCmsPlugin\Entity\SectionInterface"> | |||
| <many-to-many field="collections" target-entity="BitBag\SyliusCmsPlugin\Entity\CollectionInterface"> | |||
There was a problem hiding this comment.
How doctrine would behave with changing the field name, when we have a table with data? Isn't it safer to use the "sections" column name in all mapping places? The field can stay then as "collections".
There was a problem hiding this comment.
It doesn't change anything in the database. It is only related to the $collections field in entity, but in the database we have join-column-name: section_id
Co-authored-by: Marcin Kukliński <[email protected]>
senghe
requested changes
Jun 24, 2024
senghe
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.