OP-558: Sylius 2 upgrade #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpysiak
reviewed
Oct 10, 2024
src/Resources/views/AutomaticBlacklistingConfiguration/Admin/form.html.twig
Outdated
Show resolved
Hide resolved
…delete exclude in build.yml and codding_standard.yml
dariusz-rup
force-pushed
the
feature/OP-558
branch
from
7f1d52c to
3f334ad
Compare
…s to templates, delete Resources directory
… winzou state machine in customer.yaml, update twig_hooks in yaml files
…and bundles, fix errors
…workflow, fix erors
dariusz-rup
force-pushed
the
feature/OP-558
branch
from
2c7522f to
7805483
Compare
…ver in composer.json to fix behat
senghe
requested changes
Jan 19, 2025
.../templates/bundles/SyliusAdminBundle/order/show/content/header/title_block/actions.html.twig
Outdated
Show resolved
Hide resolved
mpysiak
reviewed
Jan 23, 2025
| - { resource: "resources.yaml" } | ||
| - { resource: "services.xml" } | ||
| - { resource: "grids.yaml" } | ||
| - { resource: "state_machine.yaml" } | ||
| - { resource: "workflow.yaml" } |
There was a problem hiding this comment.
Sylius 2.0 also supports Winzou. It is not installed by default, but you can still use it. So I would suggest that plugin also support both state machines
| <argument type="service" id="form.factory" /> | ||
| <argument>%bitbag_sylius_blacklist_plugin.model.automatic_blacklisting_configuration.class%</argument> | ||
| <argument>BitBag\SyliusBlacklistPlugin\Form\Type\AutomaticBlacklistingConfigurationType</argument> | ||
| <tag name="sylius.live_component.admin" key="sylius_admin:automatic_blacklisting_configuration:form" template="@BitBagSyliusBlacklistPlugin/AutomaticBlacklistingConfiguration/Admin/form.html.twig"/> |
There was a problem hiding this comment.
It would be great if user in project could change that template without need to decorate whole service. Move add template to prop in twig_hook also. Take a look how it is done in Sylius
…o plugin directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.