Skip to content

Commit

Permalink
OP-453 - Codereview changes
Browse files Browse the repository at this point in the history
  • Loading branch information
JanPalen committed Jul 31, 2024
1 parent a825535 commit 86fa891
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 13 deletions.
10 changes: 3 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,9 @@ This **open-source plugin was developed to help the Sylius community**. If you h

## Installation
```bash
composer require bitbag/blacklist-plugin -W
composer require bitbag/blacklist-plugin --no-scripts
```

You will see error during cache:clear operation. It will disappear after whole installation process.

![Origin](doc/images/installation-error.png)

Add plugin dependencies to your `config/bundles.php` file:
```php
return [
Expand Down Expand Up @@ -226,13 +222,13 @@ Update your database schema:
doctrine:schema:update --dump-sql
```

If the list only includes changes for updating the database by adding 'fraud_status,' you can use:
If the list includes only changes for updating the database by adding 'fraud_status' you can use:

```bash
doctrine:schema:update -f
```

If there is other changes make sure that will not destroy your database schema.
If there are another changes, please make sure they will not destroy your database schema.

## Functionalities

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"require": {
"php": "^8.0 || ^8.1 || ^8.2 || ^8.3",
"sylius/sylius": "~1.12.0 || ~1.13.0",
"doctrine/annotations": "^1.13"
"doctrine/annotations": "^2.0.0"
},
"require-dev": {
"behat/behat": "^3.7.0",
Expand Down
2 changes: 1 addition & 1 deletion doc/functionalities.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Customers are divided into three types:
- whitelisted → trusted, not checked by the plugin during purchases
- neutral → regular customer who can make purchases and is checked by the plugin with every order

The customer's status can be changed manually in the customer edit panel or automatically using plugin functionalities.
The customer's status can be changed manually in the customer edit panel(admin panel) or automatically using plugin functionalities.

![Origin](images/change-status-manually.png)

Expand Down
9 changes: 5 additions & 4 deletions tests/Application/.env
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ JWT_PASSPHRASE=acme_plugin_development
MAILER_DSN=null://null
###< symfony/mailer ###

# Choose one of the transports below
# MESSENGER_TRANSPORT_DSN=amqp://guest:guest@localhost:5672/%2f/messages
# MESSENGER_TRANSPORT_DSN=doctrine://default
# MESSENGER_TRANSPORT_DSN=redis://localhost:6379/messages
###> symfony/messenger ###
MESSENGER_TRANSPORT_DSN=sync://
SYLIUS_MESSENGER_TRANSPORT_MAIN_DSN=doctrine://default
SYLIUS_MESSENGER_TRANSPORT_MAIN_FAILED_DSN=doctrine://default?queue_name=main_failed
SYLIUS_MESSENGER_TRANSPORT_CATALOG_PROMOTION_REMOVAL_DSN=doctrine://default?queue_name=catalog_promotion_removal
SYLIUS_MESSENGER_TRANSPORT_CATALOG_PROMOTION_REMOVAL_FAILED_DSN=doctrine://default?queue_name=catalog_promotion_removal_failed
###< symfony/messenger ###

0 comments on commit 86fa891

Please sign in to comment.