upgrade behats

BitBagCommerce · Jul 30, 2024 · d5c6a01 · d5c6a01
1 parent a32d48c
commit d5c6a01
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 19 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -150,14 +150,14 @@ jobs:
                   path: etc/build/
                   if-no-files-found: ignore
 
-#            - name: Failed build Slack notification
-#              uses: rtCamp/action-slack-notify@v2
-#              if: ${{ failure() && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master') }}
-#              env:
-#                  SLACK_CHANNEL: ${{ secrets.FAILED_BUILD_SLACK_CHANNEL }}
-#                  SLACK_COLOR: ${{ job.status }}
-#                  SLACK_ICON: https://github.com/rtCamp.png?size=48
-#                  SLACK_MESSAGE: ':x:'
-#                  SLACK_TITLE: Failed build on ${{ github.event.repository.name }} repository
-#                  SLACK_USERNAME: ${{ secrets.FAILED_BUILD_SLACK_USERNAME }}
-#                  SLACK_WEBHOOK: ${{ secrets.FAILED_BUILD_SLACK_WEBHOOK }}
+            - name: Failed build Slack notification
+              uses: rtCamp/action-slack-notify@v2
+              if: ${{ failure() && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master') }}
+              env:
+                  SLACK_CHANNEL: ${{ secrets.FAILED_BUILD_SLACK_CHANNEL }}
+                  SLACK_COLOR: ${{ job.status }}
+                  SLACK_ICON: https://github.com/rtCamp.png?size=48
+                  SLACK_MESSAGE: ':x:'
+                  SLACK_TITLE: Failed build on ${{ github.event.repository.name }} repository
+                  SLACK_USERNAME: ${{ secrets.FAILED_BUILD_SLACK_USERNAME }}
+                  SLACK_WEBHOOK: ${{ secrets.FAILED_BUILD_SLACK_WEBHOOK }}
diff --git a/features/banner.feature b/features/banner.feature
@@ -14,20 +14,20 @@ Feature: Adding a new banner
     @ui
     Scenario: Adding a new banner
         When I fill form with "TEST-SECTION" section, "TEST-AD" ad, "en_US" and "100" priority
-        And I add new image "ford.jpg" and fill alt as "test-alt" and link as "http://127.0.0.1:8000/en_US"
+        And I add new image "ford.jpg" and fill alt as "test-alt" and link as "http://127.0.0.1:8080/en_US"
         And I submit form
         Then I should be notified that it has been successfully created
         And "TEST-AD" ad should has 1 banners
 
     @ui
     Scenario: Adding 2 banners to one ad
         When I fill form with "TEST-SECTION" section, "TEST-AD" ad, "en_US" and "100" priority
-        And I add new image "ford.jpg" and fill alt as "test-alt" and link as "http://127.0.0.1:8000/en_US"
+        And I add new image "ford.jpg" and fill alt as "test-alt" and link as "http://127.0.0.1:8080/en_US"
         And I submit form
         Then I should be notified that it has been successfully created
         And I am on new banner page
         And I fill form with "TEST-SECTION" section, "TEST-AD" ad, "en_US" and "150" priority
-        And I add new image "troll.jpg" and fill alt as "test-alt" and link as "http://127.0.0.1:8000/en_US"
+        And I add new image "troll.jpg" and fill alt as "test-alt" and link as "http://127.0.0.1:8080/en_US"
         And I submit form
         Then I should be notified that it has been successfully created
         And "TEST-AD" ad should has 2 banners
diff --git a/tests/Behat/Page/Admin/BannerPage.php b/tests/Behat/Page/Admin/BannerPage.php
@@ -90,7 +90,7 @@ protected function getDefinedElements(): array
             'banner_section_field' => '#bitbag_sylius_banner_plugin_banner_section',
             'banner_priority_field' => '#bitbag_sylius_banner_plugin_banner_priority',
             'banner_ad_field' => '#bitbag_sylius_banner_plugin_banner_ads',
-            'banner_file_field' => '#bitbag_sylius_banner_plugin_banner_file',
+            'banner_file_field' => 'input[name="bitbag_sylius_banner_plugin_banner[file]"]',
             'banner_link_field' => '#bitbag_sylius_banner_plugin_banner_link',
             'banner_alt_field' => '#bitbag_sylius_banner_plugin_banner_alt',
         ]);

diff --git a/tests/Behat/Resources/suites/ui/admin/ad.yaml b/tests/Behat/Resources/suites/ui/admin/ad.yaml
@@ -14,4 +14,4 @@ default:
                 - bitbag.sylius_banner_plugin.behat.context.ui.admin.ad_context
 
             filters:
-                tags: "@managing_ad && @ui"
+                tags: "@managing_ad&&@ui"
diff --git a/tests/Behat/Resources/suites/ui/admin/banner.yaml b/tests/Behat/Resources/suites/ui/admin/banner.yaml
@@ -17,4 +17,4 @@ default:
                 - bitbag.sylius_banner_plugin.behat.transformer.ad_transformer
 
             filters:
-                tags: "@managing_banners && @ui"
+                tags: "@managing_banners&&@ui"
diff --git a/tests/Behat/Resources/suites/ui/admin/section.yaml b/tests/Behat/Resources/suites/ui/admin/section.yaml
@@ -14,4 +14,4 @@ default:
                 - bitbag.sylius_banner_plugin.behat.context.ui.admin.section_context
 
             filters:
-                tags: "@managing_sections && @ui"
+                tags: "@managing_sections&&@ui"
diff --git a/tests/Behat/Resources/suites/ui/shop/banners.yaml b/tests/Behat/Resources/suites/ui/shop/banners.yaml
@@ -23,4 +23,4 @@ default:
                 - bitbag.sylius_banner_plugin.behat.transformer.ad_transformer
 
             filters:
-                tags: "@showing_banners && @ui"
+                tags: "@showing_banners&&@ui"