coding standards

.github/CODEOWNERS

@@ -1 +1,2 @@
+* @BitBagCommerce
 * @Sylius/core-team

.github/workflows/build.yml

@@ -6,7 +6,7 @@ on:
             - 'dependabot/**'
     pull_request: ~
     release:
-        types: [ created ]
+        types: [created]
     schedule:
         - cron: "0 1 * * 6" # Run at 1am every Saturday
     workflow_dispatch: ~
@@ -16,7 +16,7 @@ jobs:
         runs-on: ubuntu-latest
 
         name: "Sylius ${{ matrix.sylius }}, PHP ${{ matrix.php }}, Symfony ${{ matrix.symfony }}, 
-  MySQL ${{ matrix.mysql }}, State Machine Adapter ${{ matrix.state_machine_adapter }}"
+  MySQL ${{ matrix.mysql }}"
 
         strategy:
             fail-fast: false
@@ -26,11 +26,8 @@ jobs:
                 sylius: ["~1.12.0", "~1.13.0"]
                 node: ["^20.x"]
                 mysql: ["8.0"]
-                state_machine_adapter: ["winzou_state_machine", "symfony_workflow"]
 
                 exclude:
-                    - sylius: "~1.12.0"
-                      state_machine_adapter: "symfony_workflow"
                     - sylius: "~1.13.0"
                       php: "8.0"
 
@@ -133,8 +130,11 @@ jobs:
             - name: Validate database schema
               run: (cd tests/Application && bin/console doctrine:schema:validate)
 
+            - name: Run PHPStan
+              run: vendor/bin/phpstan analyse -c phpstan.neon -l 8 src/
+
             - name: Run ECS
-              run: vendor/bin/ecs check src
+              run: vendor/bin/ecs check src tests/Behat
 
             - name: Run PHPSpec
               run: vendor/bin/phpspec run --ansi -f progress --no-interaction

src/Controller/Action/CountClicksAction.php

@@ -26,7 +26,7 @@ final class CountClicksAction
 
     public function __construct(
         BannerRepositoryInterface $bannerRepository,
-        ObjectManager $objectManager
+        ObjectManager $objectManager,
     ) {
         $this->bannerRepository = $bannerRepository;
         $this->objectManager = $objectManager;

src/DataProvider/GetAdsBannersDataProvider.php

@@ -32,15 +32,15 @@ public function __construct(AdRepositoryInterface $adRepository, BannersProvider
     public function supports(
         string $resourceClass,
         string $operationName = null,
-        array $context = []
+        array $context = [],
     ): bool {
         return Banner::class === $resourceClass;
     }
 
     public function getCollection(
         string $resourceClass,
         string $operationName = null,
-        array $context = []
+        array $context = [],
     ): iterable {
         $localeCode = $context['filters']['locale_code'] ?? null;
         $sectionCode = $context['filters']['section_code'] ?? null;

src/Generator/BannerPathGenerator.php

@@ -25,7 +25,7 @@ public function generate(BannerInterface $banner): string
 
         return $this->expandPath(
             sprintf('%s.%s', $hash, $file->guessExtension()),
-            self::PATH_PREFIX
+            self::PATH_PREFIX,
         );
     }
 
@@ -36,7 +36,7 @@ private function expandPath(string $path, string $pathPrefix): string
             $pathPrefix,
             substr($path, 0, 2),
             substr($path, 2, 2),
-            substr($path, 4)
+            substr($path, 4),
         );
     }
 }

src/Operator/BannersOperator.php

@@ -20,7 +20,7 @@ final class BannersOperator implements BannersOperatorInterface
     public function operate(
         AdInterface $ad,
         string $sectionCode,
-        string $localeCode
+        string $localeCode,
     ): ?array {
         /** @var Collection<int, BannerInterface> $adBanners */
         $adBanners = $ad->getBanners();
@@ -44,7 +44,7 @@ public function operate(
     private function filterBannersBySectionAndLocale(
         Collection $adBanners,
         string $sectionCode,
-        string $localeCode
+        string $localeCode,
     ): Collection {
         return $adBanners->filter(function (BannerInterface $banner) use ($sectionCode, $localeCode) {
             if (null !== $banner->getLocale() &&

src/Operator/BannersOperatorInterface.php

@@ -18,6 +18,6 @@ interface BannersOperatorInterface
     public function operate(
         AdInterface $ad,
         string $sectionCode,
-        string $localeCode
+        string $localeCode,
     ): ?array;
 }

src/Provider/BannersProvider.php

@@ -26,7 +26,7 @@ public function __construct(BannersOperatorInterface $bannersOperator)
     public function getAdsBanners(
         array $ads,
         string $sectionCode,
-        string $localeCode
+        string $localeCode,
     ): ?array {
         $banners = [];
 
@@ -44,7 +44,7 @@ public function getAdsBanners(
     public function getAdBanners(
         AdInterface $ad,
         string $sectionCode,
-        string $localeCode
+        string $localeCode,
     ): ?array {
         return $this->bannersOperator->operate($ad, $sectionCode, $localeCode);
     }

src/Provider/BannersProviderInterface.php

@@ -1,14 +1,14 @@
 <?php
 
-declare(strict_types=1);
-
 /*
  * This file has been created by developers from BitBag.
  * Feel free to contact us once you face any issues or want to start
  * You can find more information about us on https://bitbag.io and write us
  * an email on [email protected].
  */
 
+declare(strict_types=1);
+
 namespace BitBag\SyliusBannerPlugin\Provider;
 
 use BitBag\SyliusBannerPlugin\Entity\AdInterface;
@@ -18,12 +18,12 @@ interface BannersProviderInterface
     public function getAdsBanners(
         array $ads,
         string $sectionCode,
-        string $localeCode
+        string $localeCode,
     ): ?array;
 
     public function getAdBanners(
         AdInterface $ad,
         string $sectionCode,
-        string $localeCode
+        string $localeCode,
     ): ?array;
 }

src/Twig/Extension/BannerExtension.php

@@ -38,7 +38,7 @@ public function getFunctions(): array
 
     public function getActiveAdsBannersBySectionAndLocale(
         string $sectionCode,
-        string $localeCode
+        string $localeCode,
     ): ?array {
         $ads = $this->adRepository->findAllActiveAds();
 
@@ -52,7 +52,7 @@ public function getActiveAdsBannersBySectionAndLocale(
     public function getActiveAdBannersByCodeSectionAndLocale(
         string $adCode,
         string $sectionCode,
-        string $localeCode
+        string $localeCode,
     ): ?array {
         $ad = $this->adRepository->findActiveAdByCode($adCode);
 

src/Uploader/BannerUploader.php

@@ -53,7 +53,7 @@ public function upload(BannerInterface $banner): void
 
         $this->filesystem->write(
             $path,
-            $fileContents
+            $fileContents,
         );
     }
 

tests/Behat/Context/Setup/Admin/BannerSetupContext.php

@@ -48,7 +48,7 @@ public function __construct(
         FactoryInterface $bannerFactory,
         ObjectRepository $localeRepository,
         BannerPage $bannerPage,
-        BannerRepository $bannerRepository
+        BannerRepository $bannerRepository,
     ) {
         $this->adRepository = $adRepository;
         $this->sectionRepository = $sectionRepository;
@@ -82,7 +82,7 @@ public function theStoreHasSectionWithCode(string $code)
     public function theStoreHasActiveAdWithCode(
         string $code,
         int $priority,
-        string $name
+        string $name,
     ) {
         /** @var AdInterface $ad */
         $ad = $this->adFactory->createNew();
@@ -103,7 +103,7 @@ public function theStoreHasActiveAdWithCode(
     public function theStoreHasNonActiveAdWithCode(
         string $code,
         int $priority,
-        string $name
+        string $name,
     ) {
         /** @var AdInterface $ad */
         $ad = $this->adFactory->createNew();
@@ -128,7 +128,7 @@ public function theStoreHasBannerWithImageAltAndLinkInSectionAndAdWithPriorityIn
         SectionInterface $section,
         AdInterface $ad,
         int $priority,
-        string $locale
+        string $locale,
     ) {
         $locale = $this->localeRepository->findOneBy(['code' => $locale]);
 

tests/Behat/Context/Ui/Admin/AdContext.php

@@ -41,15 +41,15 @@ public function iCreateANewAdWithData(
         string $startDate,
         string $endDate,
         int $priority,
-        string $code
+        string $code,
     ) {
         $this->adPage->setAdFormData(
             $name,
             $enabled,
             $startDate,
             $endDate,
             $priority,
-            $code
+            $code,
         );
         $this->adPage->submitForm();
     }

tests/Behat/Context/Ui/Admin/BannerContext.php

@@ -27,7 +27,7 @@ final class BannerContext implements Context
 
     public function __construct(
         BannerPage $bannerPage,
-        ObjectManager $manager
+        ObjectManager $manager,
     ) {
         $this->bannerPage = $bannerPage;
         $this->manager = $manager;
@@ -66,7 +66,7 @@ public function iFillFormWithAndPriority(
         SectionInterface $sectionCode,
         AdInterface $adCode,
         string $locale,
-        int $priority
+        int $priority,
     ) {
         $this->bannerPage->fillGeneralInfoForm($sectionCode, $adCode, $locale, $priority);
     }
@@ -77,7 +77,7 @@ public function iFillFormWithAndPriority(
     public function iAddNewImageAndFillAltAsAndLinksAs(
         string $image,
         string $alt,
-        string $link
+        string $link,
     ) {
         $this->bannerPage->fillBannerInfoForm($alt, $link);
         $this->bannerPage->attachImage($image);

tests/Behat/Context/Ui/Admin/SectionContext.php

@@ -31,7 +31,7 @@ public function iCreateANewSectionWithData(
         string $name,
         string $code,
         int $width,
-        int $height
+        int $height,
     ) {
         $this->sectionPage->setSectionData($name, $code, $width, $height);
         $this->sectionPage->submitForm();

tests/Behat/Page/Admin/AdPage.php

@@ -26,7 +26,7 @@ public function setSectionData(
         string $name,
         string $code,
         int $width,
-        int $height
+        int $height,
     ): void {
         $this->getElement('section_name_field')->setValue($name);
         $this->getElement('section_code_field')->setValue($code);
@@ -57,7 +57,7 @@ public function setAdFormData(
         string $startDate,
         string $endDate,
         int $priority,
-        string $code
+        string $code,
     ) {
         $this->getElement('section_name_field')->setValue($name);
         $this->getElement('section_code_field')->setValue($code);