forked from valkey-io/valkey-glide
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Add expire
, expireAt
, pexpire
, pexpireAt
and ttl
commands
#96
Merged
SanHalacogluImproving
merged 8 commits into
java/integ_SanH_add_expire_ttl_commands
from
java/dev_acarbo_add_expire_ttl_commands
Feb 23, 2024
Merged
Java: Add expire
, expireAt
, pexpire
, pexpireAt
and ttl
commands
#96
SanHalacogluImproving
merged 8 commits into
java/integ_SanH_add_expire_ttl_commands
from
java/dev_acarbo_add_expire_ttl_commands
Feb 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/ExpireOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/ExpireOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/ExpireOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/ExpireOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
aaron-congo
reviewed
Feb 15, 2024
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor javadoc changes
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
SanHalacogluImproving
approved these changes
Feb 23, 2024
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
SanHalacogluImproving
force-pushed
the
java/dev_acarbo_add_expire_ttl_commands
branch
from
February 23, 2024 00:38
585f18c
to
d562038
Compare
SanHalacogluImproving
changed the base branch from
java/integ_acarbo_add_expire_ttl_commands
to
main
February 23, 2024 00:41
SanHalacogluImproving
changed the base branch from
main
to
java/integ_SanH_add_expire_ttl_commands
February 23, 2024 00:45
…ds.java Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
approved these changes
Feb 23, 2024
SanHalacogluImproving
merged commit Feb 23, 2024
2de46df
into
java/integ_SanH_add_expire_ttl_commands
10 checks passed
SanHalacogluImproving
added a commit
that referenced
this pull request
Feb 29, 2024
…ands (#96) * Java: Add expire and ttl commands Signed-off-by: Andrew Carbonetto <[email protected]> * Update commands for review comments Signed-off-by: Andrew Carbonetto <[email protected]> * Minor javadoc fix Signed-off-by: Andrew Carbonetto <[email protected]> * Spotless Signed-off-by: Andrew Carbonetto <[email protected]> * Added examples in documentation. Minor format RedisClientTest. * Spotless * Update java/client/src/main/java/glide/api/commands/GenericBaseCommands.java Signed-off-by: Yury-Fridlyand <[email protected]> * Spotless --------- Signed-off-by: Andrew Carbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: SanHalacogluImproving <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.