Java benchmarks app: Add TLS flag to Lettuce/Jedis benchmarks #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+32
to
+37
| RedisURI uri = RedisURI.builder() | ||
| .withHost(host) | ||
| .withPort(port) | ||
| .withSsl(tls) | ||
| .build(); | ||
| client = RedisClient.create("redis://" + host + ":" + port); |
There was a problem hiding this comment.
uri is not used, so it should be
Suggested change
| RedisURI uri = RedisURI.builder() | |
| .withHost(host) | |
| .withPort(port) | |
| .withSsl(tls) | |
| .build(); | |
| client = RedisClient.create("redis://" + host + ":" + port); | |
| client = RedisClient.create((tls ? "rediss" : "redis") + "://" + host + ":" + port); |
or maybe better with String.format
There was a problem hiding this comment.
Sorry, that's a miss. It should be:
client = RedisClient.create(uri);
acarbonetto
force-pushed
the
java_benchmarks
branch
from
bed8235 to
c542597
Compare
|
Probably, you need to rebase/merge one more time to clean up the PR |
Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
This reverts commit d9b26a6.
Signed-off-by: acarbonetto <[email protected]>
* Add a java app to run benchmarks --------- Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
acarbonetto
force-pushed
the
java_benchmarks_tlsflag
branch
from
31e89f7 to
2d09685
Compare
|
Closing this Pull Request, and going to cherry pick changes into a new branch. Changes from this pull request got messed up from Yury's changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the benchmark app takes a tls flag (without argument) to pass to the Lettuce/Jedis clients.
Example: