Java: Modularize wrapper #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanl-bq
requested review from
aaron-congo,
Yury-Fridlyand,
acarbonetto,
Elen-Ghulam and
SanHalacogluImproving
Yury-Fridlyand
approved these changes
Apr 3, 2024
acarbonetto
reviewed
Apr 4, 2024
|
Why it triggers so much unrelated GHAs? npm-cd? |
Yeah, I'm confused by this too. My change was okay when I updated protoc just for the Java workflow. But putting it in shared dependencies seems to be causing a lot of weird failures. I'm still looking into this, but would appreciate any help. |
acarbonetto
approved these changes
Apr 4, 2024
Yury-Fridlyand
approved these changes
Apr 4, 2024
| // Line in format like: libprotoc 26.1 | ||
| int majorVersion = java.lang.Integer.parseInt(output.split(" ")[1].split("\\.")[0].trim()); | ||
| int minorVersion = java.lang.Integer.parseInt(output.split(" ")[1].split("\\.")[1].trim()); | ||
| if (majorVersion < 26 || (majorVersion == 26 && minorVersion < 1)) { |
There was a problem hiding this comment.
Is it possible to get numbers from the dependency instead of hardcoded ones?
Co-authored-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
approved these changes
Apr 5, 2024
jonathanl-bq
merged commit d145d0f
into
java/integ_lotjonat_modules
27 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes the API package only using Java's new module system. It also updates the name of our JAR from "client" to "glide-client".
This requires the upgrading protobuf to the 4.26.0-rc2 release candidate, which fixes an issue where protobuf was not a modularized project (see protocolbuffers/protobuf#12639).