Spike: returning a record replacement with glide strings. #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
reviewed
Aug 26, 2024
Yury-Fridlyand
commented
Aug 27, 2024
adarovadya
reviewed
Aug 27, 2024
node/src/BaseClient.ts
Outdated
|
|
||
| // GLideRecord for score for sorted set commands? | ||
| // TODO export | ||
| export type ElementScoreData = { element: GlideString; score: number }[]; |
There was a problem hiding this comment.
yes, I agree. This way you explicitly convey that this data type is meant for storing elements and their associated scores. This is more explicit than using GlideRecord , where the meaning of "key" and "value" might be less obvious without additional comments
adarovadya
reviewed
Aug 27, 2024
node/src/BaseClient.ts
Outdated
| }); | ||
| } | ||
|
|
||
| /** Downcast `GlideRecord` to `Record`. Use if you are 146% aware that `data` keys are always strings. */ |
adarovadya
reviewed
Aug 27, 2024
node/src/BaseClient.ts
Outdated
| ): Promise<Record<string, [string, string][]> | null> { | ||
| return this.createWritePromise(createXRevRange(key, end, start, count)); | ||
| options?: { count?: number } & DecoderOption, | ||
| ): Promise<{ entryID: GlideString; data: [string, string][] }[] | null> { |
There was a problem hiding this comment.
Does the data not need to be a GlideString?
There was a problem hiding this comment.
Update: entry ID could be given by the user, but it is still in number-like format (to be precise: "<uint>-<uint>"). I updated it by introducing
export type StreamEntryDataType = Record<string, [GlideString, GlideString][]>;Data is user data, which could contain anything
acarbonetto
reviewed
Aug 27, 2024
Yury-Fridlyand
commented
Aug 27, 2024
Co-authored-by: Andrew Carbonetto <[email protected]>
Yury-Fridlyand
merged commit 3e9264f
into
node/integ-yuryf-valkey-292-mget-mset
3 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
ClusterValuezadd- used in examples of other commands)List of commands:
LMPOPBLMPOPBZMPOPZPOPMINZPOPMAXZMPOPZDIFFWITHSCORESZINTERWITHSCORESZUNIONWITHSCORESHGETALLLSCIDX- no return type changePUBSUB NUMSUBXRANGE- no return type changeXREVRANGE- no return type changeXINFO GROUPS- no return type changeXINFO CONSUMERS- no return type changeXINFO STREAM- no return type changeXCLAIM- no return type changeXAUTOCLAIM- no return type changeXREADXREADGROUP