Java benchmarks Compare Jedis Sync benchmarking strategies #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
| ClientName.BABUSHKA_ASYNC, | ||
| ClientName.LETTUCE, | ||
| ClientName.LETTUCE_ASYNC); | ||
| ClientName.LETTUCE); |
| ClientName.JEDIS_ASYNC, | ||
| ClientName.BABUSHKA_ASYNC, | ||
| ClientName.LETTUCE_ASYNC); | ||
| case ALL_SYNC: |
| assert connectionSettings.clusterMode | ||
| : "JedisClusterClient does not support disabled clusterMode: use JedisClient instead"; | ||
|
|
||
| // TODO: use JedisCluster instead |
| // check if the pool is properly connected | ||
| try (Jedis jedis = pool.getResource()) { | ||
| assert jedis.isConnected() : "failed to connect to jedis"; | ||
| } |
There was a problem hiding this comment.
pool is auto-closed on this line
|
|
||
| @Override | ||
| public String getName() { | ||
| return "Jedis"; |
There was a problem hiding this comment.
put different names for clients
|
|
||
| @Override | ||
| public String getName() { | ||
| return "Jedis"; |
| } catch (Exception e) { | ||
| // timed out - exception from Future::get | ||
| } catch (InterruptedException interruptedException) { | ||
| interruptedException.printStackTrace(); |
| } | ||
|
|
||
| Benchmarking.printResults(Benchmarking.calculateResults(latencies), 0, iterations); | ||
| // Map<ChosenAction, Benchmarking.Operation> actions = new HashMap<>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jedis runs best when sharing pooled connections. This was observed when running different variations of the jedisclient.
Jedis: common Jedis resource
Jedis: common JedisPool
Jedis: common JedisPooled