Java: new xautoclaim #408
Closed
Java: new xautoclaim #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
2766
to
2808
| "COUNT", | ||
| Long.toString(count), | ||
| "JUSTID" |
There was a problem hiding this comment.
These two should be constants stored somewhere. I think we already have them, because other stream commands have same keywords
| * @param minIdleTime The minimum idle time for the message to be claimed. | ||
| * @param start Filters the claimed entries to those that have an ID equal or greater than the | ||
| * specified value. | ||
| * @return An array containing the following elements: - A stream ID to be used as the start |
There was a problem hiding this comment.
Why dashes in the middle of the strings? Do you want to use a list?
Try html ul and li tags for that - see other docs for example.
| * | ||
| * @see <a href ="https://valkey.io/commands/xautoclaim">valkey.io</a> for details. | ||
| * @param key The key of the stream. | ||
| * @param group The consumer group name |
There was a problem hiding this comment.
Suggested change
| * @param group The consumer group name | |
| * @param group The consumer group name. |
| * | ||
| * @see <a href ="https://valkey.io/commands/xautoclaim">valkey.io</a> for details. | ||
| * @param key The key of the stream. | ||
| * @param group The consumer group name |
There was a problem hiding this comment.
Suggested change
| * @param group The consumer group name | |
| * @param group The consumer group name. |
| * | ||
| * @see <a href ="https://valkey.io/commands/xautoclaim">valkey.io</a> for details. | ||
| * @param key The key of the stream. | ||
| * @param group The consumer group name |
There was a problem hiding this comment.
Suggested change
| * @param group The consumer group name | |
| * @param group The consumer group name. |
| * | ||
| * @see <a href ="https://valkey.io/commands/xautoclaim">valkey.io</a> for details. | ||
| * @param key The key of the stream. | ||
| * @param group The consumer group name |
There was a problem hiding this comment.
Suggested change
| * @param group The consumer group name | |
| * @param group The consumer group name. |
| * | ||
| * @see <a href ="https://valkey.io/commands/xautoclaim">valkey.io</a> for details. | ||
| * @param key The key of the stream. | ||
| * @param group The consumer group name |
There was a problem hiding this comment.
Suggested change
| * @param group The consumer group name | |
| * @param group The consumer group name. |
| * | ||
| * @see <a href ="https://valkey.io/commands/xautoclaim">valkey.io</a> for details. | ||
| * @param key The key of the stream. | ||
| * @param group The consumer group name |
There was a problem hiding this comment.
Suggested change
| * @param group The consumer group name | |
| * @param group The consumer group name. |
| * | ||
| * @see <a href ="https://valkey.io/commands/xautoclaim">valkey.io</a> for details. | ||
| * @param key The key of the stream. | ||
| * @param group The consumer group name |
There was a problem hiding this comment.
Suggested change
| * @param group The consumer group name | |
| * @param group The consumer group name. |
| * longer exist in the stream. These IDs are deleted from the Pending Entries List. | ||
| */ | ||
| public <ArgType> T xautoclaim( | ||
| @NonNull String key, |
There was a problem hiding this comment.
I think you need to use ArgType instead of String everywhere in transaction
Suggested change
| @NonNull String key, | |
| @NonNull ArgType key, |
cyip10
force-pushed
the
java/dev_xautoclaimNew
branch
from
dea790b to
26db1f4
Compare
jamesx-improving
force-pushed
the
java/dev_xautoclaimNew
branch
from
388b572 to
4a53b16
Compare
jamesx-improving
force-pushed
the
java/dev_xautoclaimNew
branch
from
f30d190 to
3649c42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
issues with the PR build
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.