-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split netty client into two files #40
Changes from 69 commits
06574ea
5990767
6ae93f5
8203c4d
e517744
2a11e9a
cbb0dcb
5f51a5b
52df672
84f0efc
1983974
6c1fb45
46d0cf6
d526f96
436da8f
016f5f6
e57c1ff
8664d05
b15f93e
1bab56a
d99d27a
540f49a
035ef20
0883985
d15ade1
e3634ba
500a043
0bf1678
12efc63
951aa8b
adc0bb6
9fc9022
111fc26
9236e9a
49654c3
b3284c1
8f1dfa5
7f690cf
d00a655
b5e9a33
3cee673
8dcfec0
a615f8a
73c448f
79459f5
c3d235a
917dd0e
9e62324
11a78a3
a2c2670
4b9f8de
d6b72ac
58f7b58
d145bdf
0b03dc5
a3075d5
5f10964
e3f7596
49c9119
dd7413b
a70c907
14d392b
058a05c
dfbd106
ea30ea1
9edb6be
986f468
d58bff9
507ef9f
9cecf23
8ffdbea
4ecd5d8
2bf997e
1aa0707
14e3e18
6d2ae81
e7ee9a9
540120e
aa5aa52
9a0c5d6
2c9aa38
fbff211
701da44
5bf6672
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,11 +23,6 @@ public String getName() { | |
return name; | ||
} | ||
|
||
@Override | ||
public void closeConnection() { | ||
testClient.closeConnection(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we not need to close the connection anymore? I'm not sure why this is removed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another client instance may still use the connection - it is common for all. |
||
} | ||
|
||
@Override | ||
public void connectToRedis() { | ||
connectToRedis(new ConnectionSettings("localhost", 6379, false, false)); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to check this in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is more verbose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While true, this change is irrelevant to the PR. We should put this in a separate PR.