Convert client count to snake case for rust benchmark. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanHalacogluImproving
requested review from
jonathanl-bq,
Yury-Fridlyand and
acarbonetto
jonathanl-bq
approved these changes
Oct 18, 2023
Yury-Fridlyand
approved these changes
Oct 18, 2023
acarbonetto
approved these changes
Oct 18, 2023
acarbonetto
pushed a commit
that referenced
this pull request
Nov 21, 2023
* Updated ClientCount to client_count for uniformity for rust.
Yury-Fridlyand
added a commit
that referenced
this pull request
Nov 22, 2023
commit b50d57e Author: Yury-Fridlyand <[email protected]> Date: Tue Nov 21 18:16:20 2023 -0800 Java client jni netty (#32) * Add Java-client benchmarking app Signed-off-by: acarbonetto <[email protected]> * spotless apply Signed-off-by: acarbonetto <[email protected]> * Update on command line options Signed-off-by: acarbonetto <[email protected]> * Update README Signed-off-by: acarbonetto <[email protected]> * Spotless apply: Signed-off-by: acarbonetto <[email protected]> * Update README example Signed-off-by: acarbonetto <[email protected]> * update commandline defaults for review comments Signed-off-by: acarbonetto <[email protected]> * Remove TLS flag argument from option Signed-off-by: acarbonetto <[email protected]> * Add lettuce clients for benchmarking Signed-off-by: acarbonetto <[email protected]> * Spotless apply Signed-off-by: acarbonetto <[email protected]> * Add Jedis clients Signed-off-by: acarbonetto <[email protected]> * Add to app Signed-off-by: acarbonetto <[email protected]> * Add for-loop for data size list Signed-off-by: acarbonetto <[email protected]> * Add TPS for all async items Signed-off-by: acarbonetto <[email protected]> * spotless apply Signed-off-by: acarbonetto <[email protected]> * Fix TPS calculations Signed-off-by: acarbonetto <[email protected]> * Accept TLS as a flag Signed-off-by: acarbonetto <[email protected]> * Start threads; then wait for results Signed-off-by: acarbonetto <[email protected]> * Add java-jni client Signed-off-by: acarbonetto <[email protected]> * Handle Exceptions from client; add JniSyncClient fixes Signed-off-by: acarbonetto <[email protected]> * Clean up latency and add error checking Signed-off-by: acarbonetto <[email protected]> * Minor fixes. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix result printing. Signed-off-by: Yury-Fridlyand <[email protected]> * Add TPS. Signed-off-by: Yury-Fridlyand <[email protected]> * Remove duplicates. Reorganize and fix imports. Signed-off-by: Yury-Fridlyand <[email protected]> * Int ctor fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 1. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 2: connected! Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 3: `get` and `set`. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 4: benchmark. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 5: some fixes. Signed-off-by: Yury-Fridlyand <[email protected]> * Change number of threads in Benchmarking threadpool * Revert "Change number of threads in Benchmarking threadpool" This reverts commit e3f7596. * Add more flushing rules and UT. Signed-off-by: Yury-Fridlyand <[email protected]> * Client clean up. Signed-off-by: Yury-Fridlyand <[email protected]> * Client optimizations. (#37) * Client optimizations. Signed-off-by: Yury-Fridlyand <[email protected]> * minor cleanup. Signed-off-by: Yury-Fridlyand <[email protected]> * Optimize building a command. Signed-off-by: Yury-Fridlyand <[email protected]> * Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor rename. Signed-off-by: Yury-Fridlyand <[email protected]> * Clean up Redis close connection Signed-off-by: Andrew Carbonetto <[email protected]> * Clean up Redis close connection Signed-off-by: Andrew Carbonetto <[email protected]> * Minor changes. Signed-off-by: Yury-Fridlyand <[email protected]> * Add todos to closeConnection() Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * Address PR feedback. Signed-off-by: Yury-Fridlyand <[email protected]> * Rename Signed-off-by: Yury-Fridlyand <[email protected]> * Rename2 Signed-off-by: Yury-Fridlyand <[email protected]> * Fix CI Signed-off-by: Yury-Fridlyand <[email protected]> * More fixes. Signed-off-by: Yury-Fridlyand <[email protected]> * Some changes. Signed-off-by: Yury-Fridlyand <[email protected]> * add null check Signed-off-by: Yury-Fridlyand <[email protected]> * autoflush Signed-off-by: Yury-Fridlyand <[email protected]> * Apply suggestions from code review Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * minor changes Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: acarbonetto <[email protected]> Co-authored-by: Jonathan Louie <[email protected]> commit bcf188c Author: acarbonetto <[email protected]> Date: Tue Nov 14 14:54:36 2023 -0800 Clean up timer Signed-off-by: acarbonetto <[email protected]> commit 05590b0 Author: Andrew Carbonetto <[email protected]> Date: Tue Nov 14 11:41:51 2023 -0800 Java benchmarks clusters (#34) * Add lettuce cluster client when cluster mode enabled --------- Signed-off-by: Andrew Carbonetto <[email protected]> commit 30f2f62 Merge: a62fe92 8a0449d Author: acarbonetto <[email protected]> Date: Mon Nov 6 14:50:51 2023 -0800 Merge branch 'main' into java_benchmarks commit a62fe92 Author: acarbonetto <[email protected]> Date: Mon Nov 6 14:50:18 2023 -0800 fix java install_and_test script variables Signed-off-by: acarbonetto <[email protected]> commit b00a205 Merge: 9cbc9c2 d533b7f Author: Yury-Fridlyand <[email protected]> Date: Wed Oct 25 11:16:12 2023 -0700 Merge branch 'java_benchmarks' of github.com:Bit-Quill/babushka into java_benchmarks Signed-off-by: Yury-Fridlyand <[email protected]> commit 9cbc9c2 Author: Yury-Fridlyand <[email protected]> Date: Wed Oct 25 11:15:46 2023 -0700 Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> commit d533b7f Author: Yury-Fridlyand <[email protected]> Date: Tue Oct 24 17:16:12 2023 -0700 Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> commit fe9bb98 Merge: c3d235a 231a229 Author: Yury-Fridlyand <[email protected]> Date: Tue Oct 24 17:13:19 2023 -0700 Merge remote-tracking branch 'upstream/main' into java_benchmarks Signed-off-by: Yury-Fridlyand <[email protected]> commit c3d235a Author: Yury-Fridlyand <[email protected]> Date: Fri Oct 20 10:06:23 2023 -0700 Add json reporting. (#10) * Add JSON reporting. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix for #26. Signed-off-by: Yury-Fridlyand <[email protected]> * Update java/benchmarks/src/main/java/javababushka/benchmarks/utils/Benchmarking.java Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * Use `Optional`. Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR feedback. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> commit 8a0449d Author: SanHalacogluImproving <[email protected]> Date: Wed Oct 18 15:18:08 2023 -0700 Convert client count to snake case for rust benchmark. (#27) * Updated ClientCount to client_count for uniformity for rust. commit 65090b4 Author: SanHalacogluImproving <[email protected]> Date: Tue Oct 17 09:50:38 2023 -0700 Updated ClientCount to client_count for uniformity. commit 540f49a Author: Andrew Carbonetto <[email protected]> Date: Fri Oct 6 15:52:19 2023 -0700 Create clients only once per iteration (#19) Signed-off-by: acarbonetto <[email protected]> commit d99d27a Author: acarbonetto <[email protected]> Date: Fri Oct 6 14:08:29 2023 -0700 Update redis-rs to match main branch Signed-off-by: acarbonetto <[email protected]> commit 1bab56a Author: Yury-Fridlyand <[email protected]> Date: Thu Oct 5 14:01:59 2023 -0700 Add option to run tests on multiple clients in concurrency (#16) * Add option to run tests on multiple clients in concurrency * Common pool of iterations. * Awaiting result from async methods. Signed-off-by: Yury-Fridlyand <[email protected]> * minor fix Signed-off-by: Yury-Fridlyand <[email protected]> * Change while-loop; Spotless Apply Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: acarbonetto <[email protected]> Co-authored-by: acarbonetto <[email protected]> commit b15f93e Author: Yury-Fridlyand <[email protected]> Date: Wed Sep 27 10:02:38 2023 -0700 Add missing renames. (#17) Signed-off-by: Yury-Fridlyand <[email protected]> commit 8664d05 Author: Andrew Carbonetto <[email protected]> Date: Tue Sep 26 15:27:11 2023 -0700 Rename jabushka to javababushka (#14) Signed-off-by: acarbonetto <[email protected]> commit e57c1ff Author: Yury-Fridlyand <[email protected]> Date: Mon Sep 25 17:25:41 2023 -0700 Add dataSize option to java benchmark. (#11) * Add Jedis and Lettuce benchmarks * Start ignoring .gradle files * Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> * Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> * Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> * Add benchmarks for GET non-existing * Revert "Update gitignore and remove generated files from git" This reverts commit d9b26a6. * fix redis-rs submodules Signed-off-by: acarbonetto <[email protected]> * Randomize commands in Java benchmarks * rename chooseAction to randomAction * Add a Java benchmarking app (#7) * Add a java app to run benchmarks --------- Signed-off-by: acarbonetto <[email protected]> * Add Readme and update install_and_test script to runJava Signed-off-by: acarbonetto <[email protected]> * Add Readme and update install_and_test script to runJava Signed-off-by: acarbonetto <[email protected]> * Combine java pipeline and java benchmarks (#8) * Merge Pull Request #5 - Add java pipeline. Also changed: * Merged two projects. * Updated CI. * Fixed tests and updated `junit` version. * Spotless. * Add new gradle tasks. Signed-off-by: Yury-Fridlyand <[email protected]> * Add sync and async clients both to tests. (#12) * Add sync and async clients both to tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> * Add dataSize option to java benchmark. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Jonathan Louie <[email protected]> Co-authored-by: acarbonetto <[email protected]> Co-authored-by: jonathanl-bq <[email protected]> commit 016f5f6 Author: acarbonetto <[email protected]> Date: Mon Sep 25 15:10:47 2023 -0700 Move duplicated logic in benchmark JS scripts to a single file, and convert to TypeScript. (valkey-io#456) removed duplicated logic and refactored to typescript Signed-off-by: acarbonetto <[email protected]> commit 436da8f Author: Yury-Fridlyand <[email protected]> Date: Mon Sep 25 13:58:01 2023 -0700 Add sync and async clients both to tests. (#12) * Add sync and async clients both to tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> commit d526f96 Author: Yury-Fridlyand <[email protected]> Date: Thu Sep 21 17:37:59 2023 -0700 Combine java pipeline and java benchmarks (#8) * Merge Pull Request #5 - Add java pipeline. Also changed: * Merged two projects. * Updated CI. * Fixed tests and updated `junit` version. * Spotless. * Add new gradle tasks. Signed-off-by: Yury-Fridlyand <[email protected]> commit 46d0cf6 Author: acarbonetto <[email protected]> Date: Wed Sep 20 00:42:14 2023 -0700 Add Readme and update install_and_test script to runJava Signed-off-by: acarbonetto <[email protected]> commit 6c1fb45 Author: acarbonetto <[email protected]> Date: Wed Sep 20 00:40:10 2023 -0700 Add Readme and update install_and_test script to runJava Signed-off-by: acarbonetto <[email protected]> commit 1983974 Author: Andrew Carbonetto <[email protected]> Date: Tue Sep 19 18:24:20 2023 -0700 Add a Java benchmarking app (#7) * Add a java app to run benchmarks --------- Signed-off-by: acarbonetto <[email protected]> commit 84f0efc Author: Jonathan Louie <[email protected]> Date: Thu Sep 14 16:09:11 2023 -0700 rename chooseAction to randomAction commit 52df672 Author: Jonathan Louie <[email protected]> Date: Wed Sep 13 16:04:03 2023 -0700 Randomize commands in Java benchmarks commit 5f51a5b Author: acarbonetto <[email protected]> Date: Fri Sep 8 15:47:00 2023 -0700 fix redis-rs submodules Signed-off-by: acarbonetto <[email protected]> commit cbb0dcb Author: acarbonetto <[email protected]> Date: Fri Sep 8 15:36:45 2023 -0700 Revert "Update gitignore and remove generated files from git" This reverts commit d9b26a6. commit 2a11e9a Author: Jonathan Louie <[email protected]> Date: Fri Sep 8 14:58:41 2023 -0700 Add benchmarks for GET non-existing commit e517744 Author: acarbonetto <[email protected]> Date: Fri Sep 8 13:45:34 2023 -0700 Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> commit 8203c4d Author: acarbonetto <[email protected]> Date: Fri Sep 8 13:30:53 2023 -0700 Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> commit 6ae93f5 Author: acarbonetto <[email protected]> Date: Tue Oct 3 13:35:07 2023 -0700 Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> commit 5990767 Author: Jonathan Louie <[email protected]> Date: Thu Sep 7 17:54:15 2023 -0700 Start ignoring .gradle files commit 06574ea Author: Jonathan Louie <[email protected]> Date: Wed Sep 6 20:35:12 2023 -0700 Add Jedis and Lettuce benchmarks Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.