Implement Go benchmarking #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return results | ||
| } | ||
|
|
||
| func average(observations []time.Duration) time.Duration { |
There was a problem hiding this comment.
Is there a 3rd party go lib to calc stddev, avg and percentile?
go/benchmarks/benchmarking.go
Outdated
| var jsonResults []map[string]interface{} | ||
|
|
||
| func writeResults(file *os.File) error { | ||
| encoder := json.NewEncoder(file) |
There was a problem hiding this comment.
Do this extend existing file or overwrite it?
There was a problem hiding this comment.
Should extend, because benchmarking script calls bencmarking app multiple time with different parameters
Comment on lines
+55
to
+58
| for _, clientName := range runConfig.clientNames { | ||
| for _, numConcurrentTasks := range runConfig.concurrentTasks { | ||
| for _, clientCount := range runConfig.clientCount { | ||
| for _, dataSize := range runConfig.dataSize { |
|
I tried checking out your branch and running the benchmarks locally, but I got this error: I also think the instructions for running the benchmarks should probably be documented somewhere (DEVELOPER.md?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run: