Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Add XADD command (Stream commands) #155

Merged
merged 7 commits into from
Apr 1, 2024
Merged

Java: Add XADD command (Stream commands) #155

merged 7 commits into from
Apr 1, 2024

Conversation

acarbonetto
Copy link

@acarbonetto acarbonetto self-assigned this Mar 22, 2024
SanHalacogluImproving
SanHalacogluImproving reviewed Mar 22, 2024
View reviewed changes
java/client/src/main/java/glide/api/BaseClient.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/BaseClient.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java Show resolved Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Outdated Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 25, 2024
View reviewed changes
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Show resolved Hide resolved
java/integTest/src/test/java/glide/SharedCommandTests.java Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand approved these changes Mar 26, 2024
View reviewed changes
Copy link

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things left

java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Show resolved Hide resolved
java/integTest/src/test/java/glide/SharedCommandTests.java Show resolved Hide resolved
java/client/src/main/java/glide/api/models/commands/StreamAddOptions.java Outdated

protected abstract String getThreshold();

public List<String> addTrimOptions() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency with other options

@acarbonetto
Add Stream XADD command to Java
8da9665 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Update javadoc; add option tests
bd41403 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Address comments
3907a6d 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Spotless
98aafb5 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Update StreamAddOptions for comments
f4735dd 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Add javadocs for trim options
3df1021 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto force-pushed the java/dev_acarbo_add_xadd branch from ccf423d to 3df1021 Compare April 1, 2024 19:10
@acarbonetto
Spotless
a193266 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto changed the base branch from java/integ_acarbo_add_xadd to main April 1, 2024 19:15
@acarbonetto acarbonetto changed the base branch from main to java/integ_acarbo_add_xadd April 1, 2024 19:15
@acarbonetto acarbonetto merged commit 187dd42 into java/integ_acarbo_add_xadd Apr 1, 2024
47 of 51 checks passed
@acarbonetto acarbonetto deleted the java/dev_acarbo_add_xadd branch April 1, 2024 19:44
acarbonetto added a commit that referenced this pull request Apr 1, 2024
@acarbonetto
Java: Add XADD command (Stream commands) (#155)
46cc4df 
* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto added a commit that referenced this pull request Apr 3, 2024
@acarbonetto
Java: Add XADD command (Stream commands) (#155)
8ba6f4b 
* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto added a commit that referenced this pull request Apr 4, 2024
@acarbonetto
Java: Add XADD command (Stream commands) (#155)
acb6f47 
* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto added a commit that referenced this pull request Apr 4, 2024
@acarbonetto
Java: Add XADD command (Stream commands) (#155)
01dfaa6 
* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Yury-Fridlyand pushed a commit that referenced this pull request Apr 4, 2024
@acarbonetto @SanHalacogluImproving
Java: Add XADD command (Stream commands) (valkey-io#1209)
dde7760 
* Java: Add XADD command (Stream commands) (#155)

Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: SanHalacogluImproving <[email protected]>
acarbonetto added a commit that referenced this pull request Apr 8, 2024
@acarbonetto
Java: Add XADD command (Stream commands) (#155)
e293dc2 
* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto added a commit that referenced this pull request Apr 10, 2024
@acarbonetto
Java: Add XADD command (Stream commands) (#155)
fc8bc2a 
* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Yury-Fridlyand added a commit that referenced this pull request Apr 10, 2024
@acarbonetto @SanHalacogluImproving @Yury-Fridlyand
Java/Node: Update docs for xadd and xtrim (valkey-io#1246)
0a430cf 
* Java: Add XADD command (Stream commands) (#155)

* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>

* Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)

* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* Clean up merge

Signed-off-by: Andrew Carbonetto <[email protected]>

* Move xadd command

Signed-off-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* PR comments.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Update xtrim documentation

Signed-off-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: SanHalacogluImproving <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
alex-arzola-imp pushed a commit that referenced this pull request Apr 12, 2024
@acarbonetto @SanHalacogluImproving
@Yury-Fridlyand @alex-arzola-imp
Java/Node: Update docs for xadd and xtrim (valkey-io#1246)
1fd9f43 
* Java: Add XADD command (Stream commands) (#155)

* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>

* Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)

* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* Clean up merge

Signed-off-by: Andrew Carbonetto <[email protected]>

* Move xadd command

Signed-off-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* PR comments.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Update xtrim documentation

Signed-off-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: SanHalacogluImproving <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
cyip10 pushed a commit that referenced this pull request Jun 24, 2024
@acarbonetto @SanHalacogluImproving @cyip10
Java: Add XADD command (Stream commands) (valkey-io#1209)
49bb9f0 
* Java: Add XADD command (Stream commands) (#155)

Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: SanHalacogluImproving <[email protected]>
cyip10 pushed a commit that referenced this pull request Jun 24, 2024
@acarbonetto @SanHalacogluImproving
@Yury-Fridlyand @cyip10
Java/Node: Update docs for xadd and xtrim (valkey-io#1246)
6a58fa2 
* Java: Add XADD command (Stream commands) (#155)

* Add Stream XADD command to Java

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>

* Java: Add Zpopmax command. (Sorted Set Commands) (valkey-io#1164)

* Java: Add Zpopmax command. (Sorted Set Commands) (#149)

* Minor documentation update.

* Minor test update.

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* Minor documentation update.

* Rebase + Spotless

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* Clean up merge

Signed-off-by: Andrew Carbonetto <[email protected]>

* Move xadd command

Signed-off-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

* PR comments.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Update xtrim documentation

Signed-off-by: Andrew Carbonetto <[email protected]>

* Spotless

Signed-off-by: Andrew Carbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: SanHalacogluImproving <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanHalacogluImproving SanHalacogluImproving SanHalacogluImproving approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees

@acarbonetto acarbonetto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acarbonetto @Yury-Fridlyand @SanHalacogluImproving