Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Added Zpopmin command. (Sorted Set Commands) #150

Merged

Conversation

SanHalacogluImproving
Copy link

No description provided.

Copy link

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Minor comments.

@@ -1241,6 +1242,43 @@ public T zcard(@NonNull String key) {
return getThis();
}

/**
* Removes and returns up to <code>count</code> members with the lowest scores from the sorted set

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above please

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit confused as to what you are referring to.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it match: SortedSetBaseCommands.java documentation

@SanHalacogluImproving SanHalacogluImproving merged commit e1c5b31 into java/integ_SanH_add_Zpopmin Mar 22, 2024
11 checks passed
Yury-Fridlyand pushed a commit that referenced this pull request Apr 1, 2024
* Java: Added Zpopmin command. (Sorted Set Commands) (#150)
@SanHalacogluImproving SanHalacogluImproving deleted the java/dev_SanH_add_Zpopmin branch April 3, 2024 21:34
cyip10 pushed a commit that referenced this pull request Jun 24, 2024
* Java: Added Zpopmin command. (Sorted Set Commands) (#150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants