forked from valkey-io/valkey-glide
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Make IT to manage redis. #116
Merged
Yury-Fridlyand
merged 3 commits into
csharp/integ_yuryf_it_use_script
from
csharp/dev_yuryf_it_use_script
Mar 4, 2024
Merged
C#: Make IT to manage redis. #116
Yury-Fridlyand
merged 3 commits into
csharp/integ_yuryf_it_use_script
from
csharp/dev_yuryf_it_use_script
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested review from
aaron-congo,
jonathanl-bq,
acarbonetto,
Elen-Ghulam and
SanHalacogluImproving
February 27, 2024 20:08
acarbonetto
reviewed
Feb 27, 2024
|
||
using Glide; | ||
|
||
// John Travolta is looking for tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
force-pushed
the
csharp/dev_yuryf_it_use_script
branch
from
February 29, 2024 23:19
b7be683
to
b077eae
Compare
Signed-off-by: Yury-Fridlyand <[email protected]>
aaron-congo
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with C# but LGTM
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
merged commit Mar 4, 2024
b382a3c
into
csharp/integ_yuryf_it_use_script
9 checks passed
Yury-Fridlyand
added a commit
that referenced
this pull request
Mar 6, 2024
* C#: Make IT to manage redis. (#116) Signed-off-by: Yury-Fridlyand <[email protected]>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* C#: Make IT to manage redis. (#116) Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tests (IT & UT)
Tests with report:
The approach is the same as for java client IT.
IntegrationTestBase
class provides API to get redis ports, redis version and start/stop new instance.