C#: rework CI to run tests and minimal benchmark #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
reviewed
Feb 22, 2024
| - name: Test dotnet ${{ matrix.dotnet }} | ||
| working-directory: ./csharp | ||
| run: dotnet test --framework net${{ matrix.dotnet }} /warnaserror | ||
| run: dotnet test --framework net${{ matrix.dotnet }} "-l:html;LogFileName=TestReport.html" --results-directory . -warnaserror |
There was a problem hiding this comment.
Can you call the test report something like CSharpUnitTestReport.html so that the artefact is a little more specific?
There was a problem hiding this comment.
This is an IT test report actually.
I hope we will have two reports later and I'll give them proper names.
acarbonetto
approved these changes
Feb 22, 2024
aaron-congo
reviewed
Feb 22, 2024
| @@ -8,64 +8,88 @@ on: | |||
| - glide-core/** | |||
| - submodules/** | |||
| - .github/workflows/csharp.yml | |||
| - .github/workflows/install-shared-dependencies/action.yml | |||
There was a problem hiding this comment.
I noticed there are some differences between the client CI workflows here. Do we need to align so that all clients have the same paths listed here and under pull_request?
There was a problem hiding this comment.
Yes
I added these references here, because they are used below
Yury-Fridlyand
merged commit 5ab045c
into
csharp/integ_yuryf_fix_install_in_ci
16 of 19 checks passed
Yury-Fridlyand
added a commit
that referenced
this pull request
Feb 29, 2024
* Update CI. --------- Signed-off-by: Yury-Fridlyand <[email protected]>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Update CI. --------- Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
Should also fix flaky failures like this