Configure concurrency for all CI. #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
reviewed
Feb 22, 2024
| @@ -18,6 +18,10 @@ on: | |||
| permissions: | |||
| contents: read | |||
|
|
|||
| concurrency: | |||
| group: C#-${{ github.head_ref || github.ref }} | |||
There was a problem hiding this comment.
just in case, can you call it csharp-
acarbonetto
reviewed
Feb 22, 2024
| @@ -14,6 +14,10 @@ on: | |||
| - benchmarks/utilities/* | |||
| - .github/workflows/lint-ts.yml | |||
|
|
|||
| concurrency: | |||
| group: node-lint-${{ github.head_ref || github.ref }} | |||
There was a problem hiding this comment.
this one is quick, no? I'm not sure why we have a separate workflow for this, but do we really care?
...I mean, it also doesn't hurt.
acarbonetto
approved these changes
Feb 22, 2024
jonathanl-bq
approved these changes
Feb 22, 2024
Yury-Fridlyand
merged commit 252b071
into
ci/integ_yuryf_ci_concurrency
37 of 39 checks passed
SanHalacogluImproving
pushed a commit
that referenced
this pull request
Mar 12, 2024
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore CI concurrency removed in valkey-io#991.
To avoid conflicts between different CI workflows, every group name contains the wrapper name.
The purpose of this to cancel CI for a branch if it got a new commits (so new CI started).
Docs:
https://docs.github.com/en/actions/learn-github-actions/contexts
https://docs.github.com/en/actions/using-jobs/using-concurrency#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow