Skip to content

Commit

Permalink
Check lint error output
Browse files Browse the repository at this point in the history
  • Loading branch information
aaron-congo committed Mar 5, 2024
1 parent caa2dff commit 006e2ce
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 12 deletions.
11 changes: 4 additions & 7 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,17 +64,14 @@ jobs:
working-directory: ./go
run: make install-tools-go${{ matrix.go }}

- name: Build client
working-directory: ./go
run: make build

- name: Setup upterm session
uses: lhotari/action-upterm@v1

- name: Run linters
working-directory: ./go
run: make lint-ci

- name: Build client
working-directory: ./go
run: make build

- name: Run tests
working-directory: ./go
run: make test-and-report
Expand Down
4 changes: 1 addition & 3 deletions go/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ lint:
gofumpt -d .
golines --dry-run --shorten-comments -m 127 .

lint-ci:
go vet ./...
staticcheck ./...
lint-ci: lint
if [ "$$(gofumpt -l . | wc -l)" -gt 0 ]; then exit 1; fi
if [ "$$(golines -l --shorten-comments -m 127 . | wc -l)" -gt 0 ]; then exit 1; fi

Expand Down
3 changes: 1 addition & 2 deletions go/api/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,7 @@ type RedisClusterClientConfiguration struct {
baseClientConfiguration
}

// NewRedisClusterClientConfiguration returns a [RedisClusterClientConfiguration] with default configuration settings. For
// further configuration, use the [RedisClientConfiguration] With* methods.
// NewRedisClusterClientConfiguration returns a [RedisClusterClientConfiguration] with default configuration settings. For further configuration, use the [RedisClientConfiguration] With* methods.
func NewRedisClusterClientConfiguration() *RedisClusterClientConfiguration {
return &RedisClusterClientConfiguration{
baseClientConfiguration: baseClientConfiguration{},
Expand Down

0 comments on commit 006e2ce

Please sign in to comment.