This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
forked from awslabs/amazon-timestream-driver-jdbc
-
Notifications
You must be signed in to change notification settings - Fork 0
[AT-1173] Add documentation for driver set up with SQuirreL #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
reviewed
Dec 13, 2022
RoyZhang2022
force-pushed
the
royzhang2022/AT-1173/Squirrel-document
branch
from
December 14, 2022 02:23
7dda2c5
to
daffab6
Compare
README.md
Outdated
@@ -15,6 +15,8 @@ The Timestream JDBC driver is distributed as two JAR files. | |||
### JAR With All Dependencies Shaded Except SLF4J (amazon-timestream-jdbc-\<version\>-jar-with-all-dependencies.jar) | |||
This is the shaded JAR which bundles up all the required dependencies and can be used directly in Java projects and external applications, without explicitly adding external dependencies. This JAR does not relocate the classpath of SLF4J, allowing logging to be enabled in external applications. | |||
|
|||
- Instructions for using fully shaded JAR file with [SQuirreL](markdown/setup/squirrel-driver-setup.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust based on example here - https://github.com/Bit-Quill/amazon-timestream-driver-jdbc/pull/2/files#r1049204514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can work on this with documentation PR
* [AT-1174] Aqua Data studio set up documentation * Update aqua-data-studio-sign-in.png * Apply suggestions from code review Co-authored-by: andiem-bq <[email protected]> * add image for server browser and refactor documentation * Update aqua-data-studio-setup.md * Update aqua-data-studio-setup.md Co-authored-by: andiem-bq <[email protected]>
* [AT-1177] Add documentation for driver set up with Tableau * [AT-1177] fix typo in file name for README * [AT-1177] remove steps to add jdbc-timestream.tdc reason: `jdbc-timestream.tdc` is not needed for JDBC driver to function * [AT-1177] update readme for Tableau documentation * Update markdown/setup/tableau-desktop-driver-setup.md * [AT-1177] add instructions for adding connection properties * Update README.md Co-authored-by: Alexey Temnikov <[email protected]> * add known limitations Co-authored-by: Alexey Temnikov <[email protected]>
alinaliBQ
suggested changes
Dec 15, 2022
@@ -0,0 +1,55 @@ | |||
### SQuirreL SQL Client | |||
[Link to product webpage](https://sourceforge.net/projects/squirrel-sql/). | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add "Known Limitations" section for test cases that conditionally passed/failed. Example here
* Add documentation for driver set up with DbVisualizer * format adjust * document refine * rework based on comments * file name change * modify README * rework based on comments * syntax change * Update dbvisualizer-driver-setup.md Co-authored-by: RoyZhang2022 <[email protected]>
…T-1173/Squirrel-document
Closing this PR as documentation is moved to #8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for driver set up with DBeaver
Description
Add documentation for driver set up with SQuirreL
Related Issue
https://bitquill.atlassian.net/browse/AT-1173
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022