Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

[AT-1171] Add documentation for driver set up with DbVisualizer #3

Conversation

RoyZhang2022
Copy link

Add documentation for driver set up with DbVisualizer

Description
Add documentation for driver set up with DbVisualizer

Related Issue
https://bitquill.atlassian.net/browse/AT-1171

Additional Reviewers
@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022

Copy link

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions, note that new lines are required for markdown files to render properly

markdown/setup/dbvisualizer-driver-setup.md Outdated Show resolved Hide resolved
markdown/setup/dbvisualizer-driver-setup.md Outdated Show resolved Hide resolved
markdown/setup/dbvisualizer-driver-setup.md Outdated Show resolved Hide resolved
markdown/setup/dbvisualizer-driver-setup.md Outdated Show resolved Hide resolved
markdown/setup/dbvisualizer-driver-setup.md Outdated Show resolved Hide resolved
Copy link

@alinaliBQ alinaliBQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would be good if Alexey could take a look too before merging this PR

README.md Show resolved Hide resolved
Copy link

@alexey-temnikov alexey-temnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a section with known limitations (issues we found during testing).

README.md Outdated Show resolved Hide resolved
alinaliBQ and others added 8 commits December 15, 2022 12:11
* [AT-1174] Aqua Data studio set up documentation

* Update aqua-data-studio-sign-in.png

* Apply suggestions from code review

Co-authored-by: andiem-bq <[email protected]>

* add image for server browser and refactor documentation

* Update aqua-data-studio-setup.md

* Update aqua-data-studio-setup.md

Co-authored-by: andiem-bq <[email protected]>
* [AT-1177] Add documentation for driver set up with Tableau

* [AT-1177] fix typo in file name for README

* [AT-1177] remove steps to add jdbc-timestream.tdc

reason: `jdbc-timestream.tdc` is not needed for JDBC driver to function

* [AT-1177] update readme for Tableau documentation

* Update markdown/setup/tableau-desktop-driver-setup.md


* [AT-1177] add instructions for adding connection properties

* Update README.md

Co-authored-by: Alexey Temnikov <[email protected]>

* add known limitations

Co-authored-by: Alexey Temnikov <[email protected]>
@alinaliBQ
Copy link

Closing this PR as documentation is moved to #8

@alinaliBQ alinaliBQ closed this Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants