This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
forked from awslabs/amazon-timestream-driver-jdbc
-
Notifications
You must be signed in to change notification settings - Fork 0
[AT-1171] Add documentation for driver set up with DbVisualizer #3
Closed
RoyZhang2022
wants to merge
18
commits into
alinaliBQ/AT-1169/getSchemas
from
royzhang2022/AT-1171/DbVisualizer-document
Closed
[AT-1171] Add documentation for driver set up with DbVisualizer #3
RoyZhang2022
wants to merge
18
commits into
alinaliBQ/AT-1169/getSchemas
from
royzhang2022/AT-1171/DbVisualizer-document
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinaliBQ
reviewed
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added suggestions, note that new lines are required for markdown files to render properly
alinaliBQ
reviewed
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Would be good if Alexey could take a look too before merging this PR
alinaliBQ
approved these changes
Dec 12, 2022
alinaliBQ
reviewed
Dec 12, 2022
alexey-temnikov
approved these changes
Dec 14, 2022
alexey-temnikov
suggested changes
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a section with known limitations (issues we found during testing).
* [AT-1174] Aqua Data studio set up documentation * Update aqua-data-studio-sign-in.png * Apply suggestions from code review Co-authored-by: andiem-bq <[email protected]> * add image for server browser and refactor documentation * Update aqua-data-studio-setup.md * Update aqua-data-studio-setup.md Co-authored-by: andiem-bq <[email protected]>
* [AT-1177] Add documentation for driver set up with Tableau * [AT-1177] fix typo in file name for README * [AT-1177] remove steps to add jdbc-timestream.tdc reason: `jdbc-timestream.tdc` is not needed for JDBC driver to function * [AT-1177] update readme for Tableau documentation * Update markdown/setup/tableau-desktop-driver-setup.md * [AT-1177] add instructions for adding connection properties * Update README.md Co-authored-by: Alexey Temnikov <[email protected]> * add known limitations Co-authored-by: Alexey Temnikov <[email protected]>
…T-1171/DbVisualizer-document
Closing this PR as documentation is moved to #8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for driver set up with DbVisualizer
Description
Add documentation for driver set up with DbVisualizer
Related Issue
https://bitquill.atlassian.net/browse/AT-1171
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022