This repository has been archived by the owner on Jun 16, 2024. It is now read-only.
feat: smartgaps: Hide gaps if showing a single window #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to bypass precommit hooks because clang-format is complaining about existing code. |
defer
changed the title
Currently disabled by default but adds a toggle that will hide gaps if only a single window is visible. The feature is implemented both in the cpp and ts engines.
|
Wait, but we already have a such feature:
What is the difference? Yeah, the issue is actually closed #404 (comment) |
|
@defer So do you think maybe we can close this PR now as un-merged perhaps? Also (BTW) when i enable this option: "Maximize sole window" it does seem to help or partially fix some other window bug? Whereby the tiling is partially broken / semi-works. Depending on certain windows / some of the virtual desktops / virtual screens. It's all a bit new to me still. Anyhow if we can know to actual close this PR (that it does not add anything new / or better / worthwhile improvements needed). Then many thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a toggle that will hide gaps if only a single window is visible. The feature is disabled by default.
Implementation added to both the cpp and ts engines.
Breaking Changes
No
UI Changes
Test Plan
Related Issues
Closes #404